SonarQube
  1. SonarQube
  2. SONAR-2018

"Commented-out lines of code" is not defined as a rule

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.13
    • Component/s: Rules
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Same situation as with Undocumented API (SONAR-1901) - it's hard to find those lines without violations.

        Issue Links

          Activity

          Hide
          Freddy Mallet added a comment -

          Works well Evgeny. The violation message should be "This block of commented-out lines of code should be removed" instead of "It's better to remove commented-out lines of code"

          Show
          Freddy Mallet added a comment - Works well Evgeny. The violation message should be "This block of commented-out lines of code should be removed" instead of "It's better to remove commented-out lines of code"
          Hide
          Freddy Mallet added a comment -

          The next improvement to this implementation could be to group adjacent violations like :

          // generateOneViolation();
          // generateSecondViolation();
          // generateThirdViolation();

          But this is not a blocker issue to release Sonar 2.13 as is.

          Show
          Freddy Mallet added a comment - The next improvement to this implementation could be to group adjacent violations like : // generateOneViolation(); // generateSecondViolation(); // generateThirdViolation(); But this is not a blocker issue to release Sonar 2.13 as is.
          Hide
          Evgeny Mandrikov added a comment -

          Violation message changed in 19ea0e8.
          For the improvement I created separate issue - SONAR-3119

          Show
          Evgeny Mandrikov added a comment - Violation message changed in 19ea0e8 . For the improvement I created separate issue - SONAR-3119
          Hide
          Freddy Mallet added a comment -

          Manually tested

          Show
          Freddy Mallet added a comment - Manually tested
          Hide
          Freddy Mallet added a comment -

          Upcoming IT with a squid-ruling

          Show
          Freddy Mallet added a comment - Upcoming IT with a squid-ruling

            People

            • Assignee:
              Evgeny Mandrikov
              Reporter:
              Evgeny Mandrikov
            • Votes:
              9 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: