Plugin.getName() was deprecated in Sonar 2.2, but still used and can cause errors

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.8
  • Component/s: API
  • Labels:
    None

Description

Following plugin definition leads to an error during rendering plugins settings page ("/settings/index") :

public class ExamplePlugin implements Plugin {
  public String getKey() {
    return null;
  }

  public String getName() {
    return null;
  }

  public String getDescription() {
    return null;
  }

  public List<Class<? extends Extension>> getExtensions() {
    ...
  }
}

Part of error message :

Showing app/views/settings/_plugins.html.erb where line #24 raised:

undefined method `<=>' for nil:NilClass
Extracted source (around line #24):

21: </style>
22: <div id="plugins">
23: <% form_tag :controller => :settings, :action => :update do
24: plugins = controller.java_facade.getPlugins().sort {|p1,p2| p1.getName() <=> p2.getName()}
25: plugin_properties={}
26: plugins.each do |plugin|
27: properties = controller.java_facade.getPluginProperties(plugin).select do |property|

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Evgeny Mandrikov added a comment -

Fixed in r5860.

Show
Evgeny Mandrikov added a comment - Fixed in r5860.
Hide
Permalink
Simon Brandhof added a comment -

Coding rules console in the ruby part uses Plugin.getName() to display name of rules engines.

Show
Simon Brandhof added a comment - Coding rules console in the ruby part uses Plugin.getName() to display name of rules engines.
Hide
Permalink
Evgeny Mandrikov added a comment -

Simon, I suppose that repository name should be shown in that case?

Show
Evgeny Mandrikov added a comment - Simon, I suppose that repository name should be shown in that case?
Hide
Permalink
Simon Brandhof added a comment -

Yes it should. The filter "plugin" in the search form should also be renamed.

Show
Simon Brandhof added a comment - Yes it should. The filter "plugin" in the search form should also be renamed.
Hide
Permalink
Freddy Mallet added a comment -

In fact, we should introduce a new SonarPlugin entry point to prevent any misunderstanding about the useless of the getKey(), getName() and getDescription() methods.

Show
Freddy Mallet added a comment - In fact, we should introduce a new SonarPlugin entry point to prevent any misunderstanding about the useless of the getKey(), getName() and getDescription() methods.

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: