Dollars ($) are not accepted in java class names

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.8
  • Component/s: Squid
  • Labels:
    None
  • Environment:
    GNU/Linux ubuntu 10.10

Description

I have a class with a dollar $ in its name (this is allowed according to http://java.sun.com/docs/books/jls/second_edition/html/lexical.doc.html#40625). Squid treats it as an inner class (which it is not) and displays:

java.lang.IllegalArgumentException: Java inner classes are not supported : pack.Name$Test
at org.sonar.api.resources.JavaFile.<init>(JavaFile.java:93)
at org.sonar.api.resources.JavaFile.<init>(JavaFile.java:80)
at org.sonar.api.batch.SquidUtils.convertJavaFileKeyFromSquidFormat(SquidUtils.java:45)
at org.sonar.plugins.squid.bridges.ResourceIndex.loadSquidFiles(ResourceIndex.java:62)
at org.sonar.plugins.squid.bridges.ResourceIndex.loadSquidResources(ResourceIndex.java:42)
at org.sonar.plugins.squid.SquidExecutor.save(SquidExecutor.java:96)
at org.sonar.plugins.squid.SquidSensor.analyse(SquidSensor.java:82)

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. SONAR-2026 Squid extraction fails in inner class : java.lang.IllegalArgumentException: Java inner classes are not supported

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. SONAR-2677 JUnit tests containing several level of nested inner classes can't be analysed by Sonar

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Damien Cassou added a comment -

I attached a sample project which will show the issue when running 'mvn sonar:sonar'

Show
Damien Cassou added a comment - I attached a sample project which will show the issue when running 'mvn sonar:sonar'
Hide
Permalink
Simon Brandhof added a comment -

The solution is to stop throwing an exception when a java resource contains a '$' character. Indeed, we added this constraint to prevent cobertura and findbugs plugins to store any measures on inner classes but we've updated those two plugins to store measures only on existing resources

Show
Simon Brandhof added a comment - The solution is to stop throwing an exception when a java resource contains a '$' character. Indeed, we added this constraint to prevent cobertura and findbugs plugins to store any measures on inner classes but we've updated those two plugins to store measures only on existing resources

People

  • Assignee:
    Simon Brandhof
    Reporter:
    Damien Cassou
Vote (3)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: