Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.13
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      1

      Description

      Before upgrading to Checkstyle 5.5, check that it does indeed integrate the patches SonarSource provided (see related Jira tickets).

        Issue Links

          Activity

          Hide
          Mark Mielke added a comment -

          Hi Evgeny:

          You are correct. Checkstyle 5.5 continues to give these warnings. I guess I will take this up with them...

          Show
          Mark Mielke added a comment - Hi Evgeny: You are correct. Checkstyle 5.5 continues to give these warnings. I guess I will take this up with them...
          Hide
          Freddy Mallet added a comment -

          Manually tested Evgeny, but could you list in this JIRA ticket all the changes relating to this migration (mainly new rules)

          Show
          Freddy Mallet added a comment - Manually tested Evgeny, but could you list in this JIRA ticket all the changes relating to this migration (mainly new rules)
          Hide
          Evgeny Mandrikov added a comment -

          Freddy, I'm not sure that this is required since Checkstyle provides nice list of changes (in comparison with PMD) - http://checkstyle.sourceforge.net/releasenotes.html
          However here is a list of changed rules :

          • New rules from 5.2:
            • InnerTypeLast
          • Modified rules from 5.2:
            • DeclarationOrder
            • ImportOrder
          • New rules from 5.3:
            • OuterTypeFilename
            • NestedForDepth
            • MethodCount
            • OneStatementPerLine
          • Modified rules from 5.3:
            • PackageDeclaration
            • MagicNumber
            • AbstractClassName
            • AvoidStarImport
          • Modified rules from 5.4:
            • UnusedImports
            • MagicNumber
            • EqualsAvoidNull
            • IllegalThrows
            • RedundantModifier
          Show
          Evgeny Mandrikov added a comment - Freddy, I'm not sure that this is required since Checkstyle provides nice list of changes (in comparison with PMD) - http://checkstyle.sourceforge.net/releasenotes.html However here is a list of changed rules : New rules from 5.2: InnerTypeLast Modified rules from 5.2: DeclarationOrder ImportOrder New rules from 5.3: OuterTypeFilename NestedForDepth MethodCount OneStatementPerLine Modified rules from 5.3: PackageDeclaration MagicNumber AbstractClassName AvoidStarImport Modified rules from 5.4: UnusedImports MagicNumber EqualsAvoidNull IllegalThrows RedundantModifier
          Hide
          Freddy Mallet added a comment -

          Thanks Evgeny, Manually tested

          Show
          Freddy Mallet added a comment - Thanks Evgeny, Manually tested
          Hide
          Freddy Mallet added a comment -

          Upcoming IT with a checkstyle-ruling

          Show
          Freddy Mallet added a comment - Upcoming IT with a checkstyle-ruling

            People

            • Assignee:
              Evgeny Mandrikov
              Reporter:
              Simon Brandhof
            • Votes:
              13 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: