Squid Error while parsing comment

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.12
  • Fix Version/s: 2.0
  • Component/s: None
  • Labels:
    None

Description

This kind of weird comment provoque crash of the squid plugin :

/*    *//**
     * 
     * This method adds updated occurence date to the current folder's occurrence date history object.
     * 
     *//*
    private void historiseOccurrenceDate(ClaimFolder theClaimFolder, ClaimFolder theOriginalClf,
                    SGKTimestamp theTimeStamp)
    {
...
     }*/

[INFO] Executing sensor class org.sonar.plugins.squid.SquidSensor
[ERROR] Squid Error occurs when analysing :\luntbuild\work\ICS\ICS\ics-logic\src\main\java\com\sogecap\ics\claimfolder\logic\ClaimFolderLogic.java
java.lang.IllegalStateException: String should have been ended before the end of line. line = ' * This method adds updated occurence date to the current folder's occurrence date history object.'
at org.sonar.squid.text.LiteralValueHandler.matchWithEndOfLine(LiteralValueHandler.java:60) [sonar-squid-1.12.jar:na]
at org.sonar.squid.text.LinesFactory.notifyHandlersAboutEndOfLine(LinesFactory.java:95) [sonar-squid-1.12.jar:na]
at org.sonar.squid.text.LinesFactory.createNewLine(LinesFactory.java:101) [sonar-squid-1.12.jar:na]
at org.sonar.squid.text.LinesFactory.fillLines(LinesFactory.java:70) [sonar-squid-1.12.jar:na]
at org.sonar.squid.text.LinesFactory.(LinesFactory.java:55) [sonar-squid-1.12.jar:na]
at org.sonar.squid.text.Source.(Source.java:43) [sonar-squid-1.12.jar:na]
at org.sonar.squid.text.Source.(Source.java:38) [sonar-squid-1.12.jar:na]
at org.sonar.squid.text.Source.(Source.java:49) [sonar-squid-1.12.jar:na]
at org.sonar.java.ast.CheckstyleSquidBridge.createSource(CheckstyleSquidBridge.java:81) [sonar-squid-1.12.jar:na]
at org.sonar.java.ast.CheckstyleSquidBridge.beginTree(CheckstyleSquidBridge.java:69) [sonar-squid-1.12.jar:na]
at com.puppycrawl.tools.checkstyle.TreeWalker.notifyBegin(TreeWalker.java:445) [checkstyle-4.4.jar:4.4]
at com.puppycrawl.tools.checkstyle.TreeWalker.walk(TreeWalker.java:418) [checkstyle-4.4.jar:4.4]
at com.puppycrawl.tools.checkstyle.TreeWalker.process(TreeWalker.java:244) [checkstyle-4.4.jar:4.4]
at com.puppycrawl.tools.checkstyle.TreeWalker.process(TreeWalker.java:590) [checkstyle-4.4.jar:4.4]
at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:239) [checkstyle-4.4.jar:4.4]
at org.sonar.java.ast.JavaAstScanner.launchCheckstyleEngine(JavaAstScanner.java:83) [sonar-squid-1.12.jar:na]
at org.sonar.java.ast.JavaAstScanner.scanCode(JavaAstScanner.java:117) [sonar-squid-1.12.jar:na]
at org.sonar.squid.Squid.scanFiles(Squid.java:81) [sonar-squid-1.12.jar:na]
at org.sonar.plugins.squid.SquidSensor.analyse(SquidSensor.java:78) [sonar-plugin-squid-1.12-20100201113207.jar:na]
at org.sonar.batch.core.SensorsExecutor.execute(SensorsExecutor.java:59) [sonar-core-maven-plugin-20100201113207.jar:na]
at org.sonar.batch.Batch.executeJobs(Batch.java:91) [sonar-core-maven-plugin-20100201113207.jar:na]
at org.sonar.batch.Batch.analyse(Batch.java:79) [sonar-core-maven-plugin-20100201113207.jar:na]
at org.sonar.batch.Batch.start(Batch.java:54) [sonar-core-maven-plugin-20100201113207.jar:na]
at org.sonar.batch.Batch.start(Batch.java:50) [sonar-core-maven-plugin-20100201113207.jar:na]
at org.sonar.batch.BatchMojo.executeBatch(BatchMojo.java:145) [sonar-core-maven-plugin-20100201113207.jar:na]
at org.sonar.batch.BatchMojo.execute(BatchMojo.java:137) [sonar-core-maven-plugin-20100201113207.jar:na]
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:453) [maven-2.0.10-uber.jar:2.0.10]
at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:82) [sonar-maven-plugin-1.0-beta-1.jar:na]
at org.codehaus.mojo.sonar.Bootstraper.start(Bootstraper.java:65) [sonar-maven-plugin-1.0-beta-1.jar:na]
at org.codehaus.mojo.sonar.SonarMojo.execute(SonarMojo.java:117) [sonar-maven-plugin-1.0-beta-1.jar:na]
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:453) [maven-2.0.10-uber.jar:2.0.10]
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:559) [maven-2.0.10-uber.jar:2.0.10]
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:513) [maven-2.0.10-uber.jar:2.0.10]
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:483) [maven-2.0.10-uber.jar:2.0.10]
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:331) [maven-2.0.10-uber.jar:2.0.10]
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:228) [maven-2.0.10-uber.jar:2.0.10]
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:142) [maven-2.0.10-uber.jar:2.0.10]
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:336) [maven-2.0.10-uber.jar:2.0.10]
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:129) [maven-2.0.10-uber.jar:2.0.10]
at org.apache.maven.cli.MavenCli.main(MavenCli.java:301) [maven-2.0.10-uber.jar:2.0.10]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [na:1.5.0_17]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [na:1.5.0_17]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [na:1.5.0_17]
at java.lang.reflect.Method.invoke(Method.java:585) [na:1.5.0_17]
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) [classworlds-1.1.jar:1.1]
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) [classworlds-1.1.jar:1.1]
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) [classworlds-1.1.jar:1.1]
at org.codehaus.classworlds.Launcher.main(Launcher.java:375) [classworlds-1.1.jar:1.1]
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Can not execute Sonar

Embedded error: Got an exception - java.lang.IllegalStateException: String should have been ended before the end of line. line = ' * This method adds updated occurence date to the current folder's occurrence date history object.', file : D:\luntbuild\work\ICS\ICS\ics-logic\src\main\java\com\sogecap\ics\claimfolder\logic\ClaimFolderLogic.java, line : 0

Rewrite of the comment, solve the pb !

/**
 * This method adds updated occurence date to the current folder's occurrence date history object. 
 */

 /*

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. SONAR-1367 Squid doesn't manage to correctly handle adjacent comment blocks

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Hide
Permalink
Dan Diephouse added a comment -

We have the same problem:

java.lang.IllegalStateException: String should have been ended before the end of line. line = ' var src_re = /\ssrc=([\'\"])(.*?)\1/i;'

However, I don't know that we can reformat. Here is our method:

public native void triggerScripts(String html)
/*-{
//$wnd.alert('This is a JSNI call to triggerScripts');
var s_re = /(?:<script([^>])?>)((\n|\r|.)?)(?:<\/script>)/ig;
var src_re = /\ssrc=([\'\"])(.*?)\1/i;
var type_re = /\stype=([\'\"])(.*?)\1/i;
var s_match;

while ( s_match = s_re.exec( html ) ) {
var head = $doc.getElementsByTagName("head")[0];
var attrs = s_match[1];
var src_match = attrs ? attrs.match( src_re ) : false;

if ( src_match && src_match[2] ) {
// causes errors in FF when trying to add a script to HEAD,
// every script is instead moved to gwt declarations

//var s = $doc.createElement("script");
//s.src = src_match[2];
//
//var type_match = attrs.match( type_re );
//if ( type_match && type_match[2] ) { // s.type = type_match[2]; //}

//head.appendChild( s );

} else if ( s_match[2] && s_match[2].length > 0 ) {
if ( $wnd.execScript ) { $wnd.execScript( s_match[2] ); } else { $wnd.eval( s_match[2] ); }
}
}
}-*/;
}

Show
Dan Diephouse added a comment - We have the same problem: java.lang.IllegalStateException: String should have been ended before the end of line. line = ' var src_re = /\ssrc=([\'\"])(.*?)\1/i;' However, I don't know that we can reformat. Here is our method: public native void triggerScripts(String html) /*-{ //$wnd.alert('This is a JSNI call to triggerScripts'); var s_re = /(?:<script([^>])?>)((\n|\r|.)?)(?:<\/script>)/ig; var src_re = /\ssrc=([\'\"])(.*?)\1/i; var type_re = /\stype=([\'\"])(.*?)\1/i; var s_match; while ( s_match = s_re.exec( html ) ) { var head = $doc.getElementsByTagName("head")[0]; var attrs = s_match[1]; var src_match = attrs ? attrs.match( src_re ) : false; if ( src_match && src_match[2] ) { // causes errors in FF when trying to add a script to HEAD, // every script is instead moved to gwt declarations //var s = $doc.createElement("script"); //s.src = src_match[2]; // //var type_match = attrs.match( type_re ); //if ( type_match && type_match[2] ) { // s.type = type_match[2]; //} //head.appendChild( s ); } else if ( s_match[2] && s_match[2].length > 0 ) { if ( $wnd.execScript ) { $wnd.execScript( s_match[2] ); } else { $wnd.eval( s_match[2] ); } } } }-*/; }

People

  • Assignee:
    Freddy Mallet
    Reporter:
    François Houdebert
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: