Sonar

Provide a way to deactivate the NOSONAR mechanism used to flag false-positif

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.12
  • Fix Version/s: None
  • Component/s: Squid
  • Labels:
    None
  • Number of attachments :
    0

Description

With version 1.12 the NOSONAR tag has been introduced, allowing whoever has
access to the code to prevent sonar and the tools it employs to report
detected violations. Now, in our company, the policy is to not use this kind
of suppressing tags (NOPMD, NOSONAR) but to accept the occasional false
positive as the price to pay for proper, reliable reporting.

As far as I can tell, there is no way to prevent the use of NOSONAR, i.e. to
let the sonar plugin simply ignore this tag. This has been confirmed on the mailing list, see http://old.nabble.com/Disabling-use-of-NOSONAR-%28and-possible-taglist-bug-%29-to26828355.html#a26833632.

So I'd like to propose the addition of a mechanism to disable the effect of the NOSONAR tag, or make it possible to detect its use as a violation itself.

Issue Links

is related to

New Feature - A new feature of the product, which has yet to be developed. SONAR-1817 Squid rule to create violation on each NOSONAR tag occurence

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Freddy Mallet added a comment -

This metric should be directly provided by Squid.

Show
Freddy Mallet added a comment - This metric should be directly provided by Squid.
Hide
Permalink
Evgeny Mandrikov added a comment -

I suppose that this issue duplicates SONAR-1405

Show
Evgeny Mandrikov added a comment - I suppose that this issue duplicates SONAR-1405
Hide
Permalink
Simon Brandhof added a comment -

No. This issue is about the deactivation of the NOSONAR feature, whereas SONAR-1405 is to force some plugins to generate violations, even if the line is tagged with NOSONAR.

Show
Simon Brandhof added a comment - No. This issue is about the deactivation of the NOSONAR feature, whereas SONAR-1405 is to force some plugins to generate violations, even if the line is tagged with NOSONAR.
Hide
Permalink
Freddy Mallet added a comment -

A new global property must be available in the Settings page to deactivate the NOSONAR mechanism

Show
Freddy Mallet added a comment - A new global property must be available in the Settings page to deactivate the NOSONAR mechanism
Hide
Permalink
Evgeny Mandrikov added a comment - - edited

There is only two use cases with NOSONAR mechanism :

  • Some users don't allow to use //NOSONAR
  • The other ones allow to use //NOSONAR but want to regularly check that this //NOSONAR tag is correctly used

So, in both cases no need to deactivate this mechanism and SONAR-1817 will cover those cases.

Show
Evgeny Mandrikov added a comment - - edited There is only two use cases with NOSONAR mechanism : Some users don't allow to use //NOSONAR The other ones allow to use //NOSONAR but want to regularly check that this //NOSONAR tag is correctly used So, in both cases no need to deactivate this mechanism and SONAR-1817 will cover those cases.

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Joris Portegies Zwart
Vote (5)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: