Maven SCM

Git blame fails to report line authors on windows with core.autocrlf = true

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.8
  • Component/s: maven-scm-provider-git
  • Labels:
    None
  • Environment:
    Windows
    git configured with core.autocrlf = true
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

Git blame cannot report line authors when each line is modified locally by the autocrlf parameter. It thinks every line is Not Yet Committed.

The fix is to use git blame -w instead of plain git blame, to ignore whitespaces.

See discussion here: http://stackoverflow.com/questions/4638500/git-blame-showing-no-history

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. SONARPLUGINS-1995 Fail to report line authors on windows with core.autocrlf = true

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

fixed.
You will now have 

BlameScmResult blame( BlameScmRequest blameScmRequest )

with blameScmRequest.setIgnoreWhitespace( true/false )

Have fun !

Show
Olivier Lamy added a comment - fixed. You will now have BlameScmResult blame( BlameScmRequest blameScmRequest ) with blameScmRequest.setIgnoreWhitespace( true / false ) Have fun !
Hide
Permalink
David Gageot added a comment -

Any date of release?

Show
David Gageot added a comment - Any date of release?
Hide
Permalink
Jorge Costa added a comment -

Hi Olivier,

I was looking into the implementation of this feature, and at least for git i found difficult to understand how the parameter is passed to the command executor.

This is the implementation of the command:

Commandline cl = createCommandLine( workingDirectory.getBasedir(), filename,
parameters.getBoolean( CommandParameter.IGNORE_WHITESPACE, false ) );

As i understand in the new BlameScmRequest is only setting an internal boolean ignoreWhitespace to true and not the property. So i see that the ignore whitespaces is always ignored.

Is this the intended implementation, or am i not seeing everything?

Thanks in advance

Br,

Jorge Costa

Show
Jorge Costa added a comment - Hi Olivier, I was looking into the implementation of this feature, and at least for git i found difficult to understand how the parameter is passed to the command executor. This is the implementation of the command: Commandline cl = createCommandLine( workingDirectory.getBasedir(), filename, parameters.getBoolean( CommandParameter.IGNORE_WHITESPACE, false ) ); As i understand in the new BlameScmRequest is only setting an internal boolean ignoreWhitespace to true and not the property. So i see that the ignore whitespaces is always ignored. Is this the intended implementation, or am i not seeing everything? Thanks in advance Br, Jorge Costa

People

  • Assignee:
    Olivier Lamy
    Reporter:
    David Gageot
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: