Maven SCM

SvnInfoConsumer not I18N aware

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.2
  • Fix Version/s: 1.7, 1.x
  • Component/s: maven-scm-provider-svn
  • Labels:
    None
  • Environment:
    Debian GNU Linux (squeeze), Subversion 1.5.6
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

There is a problem with class org.apache.maven.scm.provider.svn.svnexe.command.info.SvnInfoConsumer - it heavely depends on:

svn --non-interactive info

result
which differs under different locale settings

It would be much better if org.apache.maven.scm.provider.svn.svnexe.command.info.SvnInfoCommand.createCommandLine(SvnScmProviderRepository, ScmFileSet, boolean, String) use:

svn --non-interactive --xml info

instead of:

svn --non-interactive info

the former produces:

<?xml version="1.0"?>
<info>
<entry
kind="dir"
path="."
revision="1647">
<url>http://javelin/svn/com.winuel.sip/trunk</url>
<repository>
<root>http://javelin/svn/com.winuel.sip</root>
<uuid>e17e3fd1-5418-7e4b-8253-85740d203573</uuid>
</repository>
<wc-info>
<schedule>normal</schedule>
<depth>infinity</depth>
</wc-info>
<commit
revision="1647">
<author>grgr</author>
<date>2009-07-14T11:49:37.776704Z</date>
</commit>
</entry>

and the latter (on my computer):

Ścieżka: .
URL: http://javelin/svn/com.winuel.sip/trunk
Katalog główny repozytorium: http://javelin/svn/com.winuel.sip
UUID repozytorium: e17e3fd1-5418-7e4b-8253-85740d203573
Wersja: 1647
Rodzaj obiektu: katalog
Zlecenie: normalne
Autor ostatniej zmiany: grgr
Ostatnio zmieniona wersja: 1647
Data ostatniej zmiany: 2009-07-14 13:49:37 +0200 (Wt)

It's obvious that this command should be locale-independent

regards
Grzegorz Grzybek

Issue Links

supercedes

Bug - A problem which impairs or prevents the functions of the product. SCM-577 SvnCheckInConsumer is "English locale" dependent

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Robert Scholte added a comment -

Fixed in r1325497
Verified by changing its value to "de", which caused some failing tests.
With "en" all svnexe tests succeed.

Show
Robert Scholte added a comment - Fixed in r1325497 Verified by changing its value to "de" , which caused some failing tests. With "en" all svnexe tests succeed.
Hide
Permalink
Chris Graham added a comment -

I have similar concerns with the Jazz provider. Jazz is internationalized. Most of (none?) Maven is not internationalised, the SCM code certainly isn't.

In fact, most of the scm providers most probably suffer from this issue.

Whilst the suggestion above appears to work for SVN, it doesn't cover the case of the other providers.

Show
Chris Graham added a comment - I have similar concerns with the Jazz provider. Jazz is internationalized. Most of (none?) Maven is not internationalised, the SCM code certainly isn't. In fact, most of the scm providers most probably suffer from this issue. Whilst the suggestion above appears to work for SVN, it doesn't cover the case of the other providers.
Hide
Permalink
Chris Graham added a comment -

Eg: SCM-577

Show
Chris Graham added a comment - Eg: SCM-577

People

  • Assignee:
    Robert Scholte
    Reporter:
    Grzegorz Grzybek
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: