Add a mojo to check for up to date local checkout

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.2
  • Component/s: maven-plugin
  • Labels:
    None
  • Complexity:
    Intermediate

Description

It would be helpful if the deploy plugin had the ability to check the local workspace against the scm (svn, cvs, etc.) to make sure that everything is up to date and there are not local changes before deploying the artifact. This would mainly be useful when deploying snapshots since the release plugin already handles this for release versions.

This would be useful to prevent someone (or at least warn them) from deploying a snapshot that cannot be reproduced.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Bentmann added a comment -

IMHO, the Deploy Plugin should not be concerned with SCM stuff, these are two different domains. I believe it would be more sensible to extend the Maven SCM Plugin with such a check such that users can bind the SCM Plugin into the build.

Show
Benjamin Bentmann added a comment - IMHO, the Deploy Plugin should not be concerned with SCM stuff, these are two different domains. I believe it would be more sensible to extend the Maven SCM Plugin with such a check such that users can bind the SCM Plugin into the build.
Hide
Permalink
Paul Gier added a comment -

Ok, I agree. I have moved the issue to the maven scm plugin.

Show
Paul Gier added a comment - Ok, I agree. I have moved the issue to the maven scm plugin.
Hide
Permalink
Olivier Lamy added a comment -

A nice feature which could prevent some issues I have seen in my company.
IMHO :

  • adding a configurable message
  • adding a skip field (false by default) and display a warning when user enable this skip field
Show
Olivier Lamy added a comment - A nice feature which could prevent some issues I have seen in my company. IMHO :
  • adding a configurable message
  • adding a skip field (false by default) and display a warning when user enable this skip field
Hide
Permalink
Olivier Lamy added a comment -

So if you want to prevent deployement you have to bind this mojo between install and deploy.but as we don't have any phase between install and deploy. The phase to bind it is install.
But it will break multi modules build if you want only install all of them. Only the first project will be installed.
So why not...

Show
Olivier Lamy added a comment - So if you want to prevent deployement you have to bind this mojo between install and deploy.but as we don't have any phase between install and deploy. The phase to bind it is install. But it will break multi modules build if you want only install all of them. Only the first project will be installed. So why not...
Hide
Permalink
Olivier Lamy added a comment -

fixed rev 757289..
snapshot deployed.
To test it :

<plugin>
  <artifactId>maven-scm-plugin</artifactId>
   <version>1.2-SNAPSHOT</version>
    <executions>
      <execution>
      <id>check-local-modification</id>
      <goals>
        <goal>check-local-modification</goal>
      </goals>
      <phase>install</phase>
    </execution>
  </executions>
</plugin>
Show
Olivier Lamy added a comment - fixed rev 757289.. snapshot deployed. To test it : 
<plugin>
  <artifactId>maven-scm-plugin</artifactId>
   <version>1.2-SNAPSHOT</version>
    <executions>
      <execution>
      <id>check-local-modification</id>
      <goals>
        <goal>check-local-modification</goal>
      </goals>
      <phase>install</phase>
    </execution>
  </executions>
</plugin>

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Paul Gier
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: