Maven SCM

can not work with local copy

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1, 1.8
  • Fix Version/s: 1.9
  • Component/s: maven-scm-provider-svn
  • Labels:
    None
  • Environment:
    Windows xp, maven 2.0.9
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

I have a need to use the SCM api to manipulate a local svn copy, but the svn provider can only work with remote copies.

e.g. "svn info ." to get the reposirory URL etc from what Subversion has and not what you think it is.

If you pass in a file:// URL it treats this as a repository and not a local copy - but if you don't use a url prefix and pass in just the path it fails to parse the URL in SvnScmProviderRepository.parseURL().

The current workaround is to provide a custom SvnScmProviderRepository which overrides getURL to return the path which shows that the info command and others can work like this (however this obviously breaks anything that uses local file based repositories!)

Issue Links

is depended upon by

Task - A task that needs to be done. MSCMPUB-3 Upgrade to SCM-1.9

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Tran added a comment -

initial discussion link

http://www.nabble.com/Maven-SCM---SVN-provider-td21358219.html

Show
Dan Tran added a comment - initial discussion link http://www.nabble.com/Maven-SCM---SVN-provider-td21358219.html
Hide
Permalink
James Nord added a comment -

Digging into this a bit more all I think is needed is changing lines 155-157 of SvnSCMProviderRepository.java from

if ( getProtocol() == null )

{ return; }

to

if ( getProtocol() == null )
{
File f = new File(url);
if (f.exists) {
this.url = url;
// can not have hosts etc in local paths so just return or surround the later code with an else

{...}

return;
}
return;
}

Show
James Nord added a comment - Digging into this a bit more all I think is needed is changing lines 155-157 of SvnSCMProviderRepository.java from if ( getProtocol() == null ) { return; } to if ( getProtocol() == null ) { File f = new File(url); if (f.exists) { this.url = url; // can not have hosts etc in local paths so just return or surround the later code with an else {...} return; } return; }
Hide
Permalink
Dan Tran added a comment -

I think http://jira.codehaus.org/browse/SCM-433 solves your case where you only want to do svn info project.getBasedir()

Show
Dan Tran added a comment - I think http://jira.codehaus.org/browse/SCM-433 solves your case where you only want to do svn info project.getBasedir()
Hide
Permalink
James Nord added a comment -

I will try that when it is released.

Show
James Nord added a comment - I will try that when it is released.
Hide
Permalink
James Nord added a comment -

Looking at that I don't think it will help as I am still required to pass in a ProviderRepository. If you pass in null (work it out) an exception is thrown.

Show
James Nord added a comment - Looking at that I don't think it will help as I am still required to pass in a ProviderRepository. If you pass in null (work it out) an exception is thrown.
Hide
Permalink
James Nord added a comment -

Digging through the code it seems like this should be supported and ends up in getRepositoryURL in SvnExeScmProvider.

However this calls info which goes out and into AbstractCommand.execute(...) which does a check against the repo.

I beleive this should call the info command directly.
.

Show
James Nord added a comment - Digging through the code it seems like this should be supported and ends up in getRepositoryURL in SvnExeScmProvider. However this calls info which goes out and into AbstractCommand.execute(...) which does a check against the repo. I beleive this should call the info command directly. .
Hide
Permalink
James Nord added a comment -

fix for issue

Show
James Nord added a comment - fix for issue
Hide
Permalink
Chris Graham added a comment -

This patch still has not been applied. It is likely to be? Or, is the issue still relevant?

Show
Chris Graham added a comment - This patch still has not been applied. It is likely to be? Or, is the issue still relevant?
Hide
Permalink
Robert Scholte added a comment -

This seems to be the reason why the junit-tests for the maven-scm-publish-plugin fail under Windows.

Show
Robert Scholte added a comment - This seems to be the reason why the junit-tests for the maven-scm-publish-plugin fail under Windows.
Hide
Permalink
Robert Scholte added a comment -

Fixed in https://git-wip-us.apache.org/repos/asf/maven-scm/commit/c96ca247
Thanks!

Show
Robert Scholte added a comment - Fixed in https://git-wip-us.apache.org/repos/asf/maven-scm/commit/c96ca247 Thanks!

People

  • Assignee:
    Robert Scholte
    Reporter:
    James Nord
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: