Maven SCM
  1. Maven SCM
  2. SCM-414

Patch Submisson Fix Maven Perforce SCM Plugin so that it will work with Continuum

    Details

    • Type: Bug Bug
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1
    • Fix Version/s: 1.x
    • Labels:
      None
    • Environment:
      Tested on linux should work on any platform.
    • Complexity:
      Intermediate
    • Patch Submitted:
      Yes
    • Number of attachments :
      2

      Description

      There are a couple of issues with picking up the perforce password.

      • Added code to pick it up from the standard environment (P4PASSWD) if not set elsewhere.
      • Changed the DataOutputStream to a OutputStreamWriter as the DataOutputStream throws in extra unicode characters

      The "file(s) up-to-date" message has a different case F on different platforms.
      Omitted it the F from the string compare.

      1. perforce.diff
        7 kB
        David Trott
      2. scm-414.patch
        0.7 kB
        Peter Janes

        Activity

        Hide
        Peter Janes added a comment -

        The previous patch touched more files than necessary. I've reduced it to only the single needed file.

        Both cases can appear, depending on whether the "p4 sync" command has an argument or not:

        $ p4 sync
        File(s) up-to-date.
        $ p4 sync ...
        ... - file(s) up-to-date.

        Show
        Peter Janes added a comment - The previous patch touched more files than necessary. I've reduced it to only the single needed file. Both cases can appear, depending on whether the "p4 sync" command has an argument or not: $ p4 sync File(s) up-to-date. $ p4 sync ... ... - file(s) up-to-date.
        Hide
        Peter Janes added a comment -

        Apologies, I was reading the patch in isolation from the report. The DataOutputStream changes do appear to be necessary.

        I proposed an alternative solution which supports P4 ticket-based login (and probably the P4PASSWD variable as well, although that's untested) in SCM-415.

        Show
        Peter Janes added a comment - Apologies, I was reading the patch in isolation from the report. The DataOutputStream changes do appear to be necessary. I proposed an alternative solution which supports P4 ticket-based login (and probably the P4PASSWD variable as well, although that's untested) in SCM-415 .

          People

          • Assignee:
            Unassigned
            Reporter:
            David Trott
          • Votes:
            3 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated: