[#SCM-370] generated client spec contains backslashes leading die problems on unix os

Maven SCM

generated client spec contains backslashes leading die problems on unix os

Created: 17/Mar/08 06:06 AM Updated: 14/May/08 04:18 PM

Component/s:

maven-scm-provider-perforce

Affects Version/s:

1.0

Fix Version/s:

1.1

Time Tracking:

Not Specified

File Attachments:

SCM-351_&_SCM-370.patch (1 kb)

Environment:

UNIX

Issue Links:

Duplicate

This issue is duplicated by:

~~SCM-351~~ generated client spec name fails if there is a space or tilde in directory name

Complexity:	Intermediate
Patch Submitted:	Yes

Description

« Hide

When a client is created it is named:

E.g. sannies-sojus-MavenSCM-\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\6

that is ok, but now comes the sync command and uses following commandline

/bin/bash c "p4 -d /opt/continuum-1.1-beta-3-SNAPSHOT/apps/continuum/webapp/WEB-INF/working-directory/1 -cbackground-sojus-MavenSCM\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\1 sync"

The Bash now removes the backslashes in the client name! The result is that the client is not existent and perforce returns with an error.
This is related to PLXUTILS-44 and CONTINUUM-1402

I propose to use the underscore character instead of the backslash.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Sebastian Annies - 17/Mar/08 06:33 AM - edited

Patch:

Modified generateDefaultClientspecName in PerforceScmProvider to generate client spec without spaces, ~ and backslashes. This will fix ~~SCM-370~~ and ~~SCM-351~~

workdir is now translated to specname this way: path = workDir.getCanonicalPath().replaceAll("[/ ~]", "-");

[ Permlink | « Hide ]

Emmanuel Venisse - 14/May/08 04:18 PM

Applied. Thanks.