[#SCM-351] generated client spec name fails if there is a space or tilde in directory name

Maven SCM

generated client spec name fails if there is a space or tilde in directory name

Created: 20/Nov/07 02:50 PM Updated: 14/May/08 04:18 PM

Component/s:

maven-scm-provider-perforce

Affects Version/s:

1.0

Fix Version/s:

1.1

Time Tracking:

Not Specified

Issue Links:

Duplicate

This issue duplicates:

~~SCM-370~~ generated client spec contains backslashes leading die problems on unix os

Complexity:

Intermediate

Description

« Hide

The default generated client spec name is calculated in generateDefaultClientspecName() as:

username + "−" + hostname + "−MavenSCM−" + path;

if path includes a space or tilde, the client spec is not created and the plugin fails to sync.

Can:

path = workDir.getCanonicalPath().replace( '/', '\\' )

be replaced with:

path = workDir.getCanonicalPath().replace( '/', '\\' ).replaceAll("[ ~]", "-")

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

zak jacobson - 20/Nov/07 02:55 PM

Here is the output.

[DEBUG] Updating clientspec:
Client: johndoe-SDGL04301175-MavenSCM-C:\Perforce Workspace\foundation\target\checkout
Root: C:\Perforce Workspace\foundation\target\checkout
Owner: johndoe

View:
        /... //johndoe-SDGL04301175-MavenSCM-C:\Perforce Workspace\foundation\target\checkout/...
Description:
        Created by maven-scm-provider-perforce

[ERROR] Unable to sync.  Are you logged in?

[ Permlink | « Hide ]

Sebastian Annies - 17/Mar/08 06:34 AM

~~SCM-370~~ is a very similar issue. I attached a patch there that will also fix this one.

[ Permlink | « Hide ]

Emmanuel Venisse - 14/May/08 04:18 PM

Fixed by ~~SCM-370~~