Maven SCM

generated client spec name fails if there is a space or tilde in directory name

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.1
  • Component/s: maven-scm-provider-perforce
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

The default generated client spec name is calculated in generateDefaultClientspecName() as:

username + "−" + hostname + "−MavenSCM−" + path;

if path includes a space or tilde, the client spec is not created and the plugin fails to sync.

Can:

path = workDir.getCanonicalPath().replace( '/', '\\' )

be replaced with:

path = workDir.getCanonicalPath().replace( '/', '\\' ).replaceAll("[ ~]", "-")

Issue Links

duplicates

Improvement - An improvement or enhancement to an existing feature or task. SCM-370 generated client spec contains backslashes leading die problems on unix os

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
zak jacobson added a comment -

Here is the output.

[DEBUG] Updating clientspec:
Client: johndoe-SDGL04301175-MavenSCM-C:\Perforce Workspace\foundation\target\checkout
Root: C:\Perforce Workspace\foundation\target\checkout
Owner: johndoe

View:
        /... //johndoe-SDGL04301175-MavenSCM-C:\Perforce Workspace\foundation\target\checkout/...
Description:
        Created by maven-scm-provider-perforce

[ERROR] Unable to sync.  Are you logged in?
Show
zak jacobson added a comment - Here is the output. [DEBUG] Updating clientspec: Client: johndoe-SDGL04301175-MavenSCM-C:\Perforce Workspace\foundation\target\checkout Root: C:\Perforce Workspace\foundation\target\checkout Owner: johndoe View: /... //johndoe-SDGL04301175-MavenSCM-C:\Perforce Workspace\foundation\target\checkout/... Description: Created by maven-scm-provider-perforce [ERROR] Unable to sync. Are you logged in?
Hide
Permalink
Sebastian Annies added a comment -

SCM-370 is a very similar issue. I attached a patch there that will also fix this one.

Show
Sebastian Annies added a comment - SCM-370 is a very similar issue. I attached a patch there that will also fix this one.
Hide
Permalink
Emmanuel Venisse added a comment -

Fixed by SCM-370

Show
Emmanuel Venisse added a comment - Fixed by SCM-370

People

  • Assignee:
    Emmanuel Venisse
    Reporter:
    zak jacobson
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: