Details

    • Type: New Feature New Feature
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: maven-scm-provider-cvs
    • Labels:
      None
    • Complexity:
      Intermediate
    • Number of attachments :
      1

      Issue Links

        Activity

        Emmanuel Venisse made changes -
        Field Original Value New Value
        Fix Version/s 1.x [ 13501 ]
        Emmanuel Venisse made changes -
        Link This issue is depended upon by MRELEASE-189 [ MRELEASE-189 ]
        Hide
        Christophe Lallement added a comment - - edited

        Hello

        I can see that the issue depend on MRELEASE-189 .
        It's not the truth, it's opposite.

        I have made a patch to add cvs edit feature
        The patch is based on the 1.0 released (svn tag).

        The fix impact 3 projects:

        • maven-scm-provider-cvs-commons
        • maven-scm-provider-cvsexe
        • maven-scm-provider-cvsjava

        I have tested the both mode (native and command line) with success.

        In fact the fix is in 2 parts:
        1/ add the features into maven scm cvs plugins
        2/ make a little patch because javacvs (netbeans) provide a default cvs command factory which does not include edit !!! (even the Edit command is present in the javacvs library ! ).

        Let me know if you plan to include this in a next release.

        Regards Christophe
        PS: it's the first time i create a svn patch, if you want i can attach the complete source.

        Show
        Christophe Lallement added a comment - - edited Hello I can see that the issue depend on MRELEASE-189 . It's not the truth, it's opposite. I have made a patch to add cvs edit feature The patch is based on the 1.0 released (svn tag). The fix impact 3 projects: maven-scm-provider-cvs-commons maven-scm-provider-cvsexe maven-scm-provider-cvsjava I have tested the both mode (native and command line) with success. In fact the fix is in 2 parts: 1/ add the features into maven scm cvs plugins 2/ make a little patch because javacvs (netbeans) provide a default cvs command factory which does not include edit !!! (even the Edit command is present in the javacvs library ! ). Let me know if you plan to include this in a next release. Regards Christophe PS: it's the first time i create a svn patch, if you want i can attach the complete source.
        Hide
        Christophe Lallement added a comment -

        diff with 1.0 tag

        Show
        Christophe Lallement added a comment - diff with 1.0 tag
        Christophe Lallement made changes -
        Attachment provider-cvs-with-edit.patch [ 30487 ]
        Emmanuel Venisse made changes -
        Description I'll look at it in details later (I don't know when) but it seems to be good, so I'll can include it.
        Hide
        Emmanuel Venisse added a comment -

        I'll look at it in details later (I don't know when) but it seems to be good, so I'll can include it.

        Show
        Emmanuel Venisse added a comment - I'll look at it in details later (I don't know when) but it seems to be good, so I'll can include it.
        Emmanuel Venisse made changes -
        Description I'll look at it in details later (I don't know when) but it seems to be good, so I'll can include it.
        Hide
        Christophe Lallement added a comment - - edited

        Hello

        Any news for integration of this patch into an official release ?
        It works "like a charm" into my company since many months.

        Regards.

        Show
        Christophe Lallement added a comment - - edited Hello Any news for integration of this patch into an official release ? It works "like a charm" into my company since many months. Regards.
        Olivier Lamy made changes -
        Fix Version/s 1.x [ 13501 ]
        Assignee Olivier Lamy [ olamy ]
        Fix Version/s 1.1.1 [ 14522 ]
        Hide
        Olivier Lamy added a comment -

        Hi,
        Can you provide a new path with the current trunk ?
        I can't commit your patch "AS IS" I have some errors when applying it.

        Thanks.

        Show
        Olivier Lamy added a comment - Hi, Can you provide a new path with the current trunk ? I can't commit your patch "AS IS" I have some errors when applying it. Thanks.
        Olivier Lamy made changes -
        Fix Version/s 1.1.1 [ 14522 ]
        Fix Version/s 1.2 [ 14523 ]
        Olivier Lamy made changes -
        Fix Version/s 1.3 [ 14523 ]
        Assignee Olivier Lamy [ olamy ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Emmanuel Venisse
          • Votes:
            4 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: