[#SCM-281] Perforce problem: incorrect client spec is used

Maven SCM

Perforce problem: incorrect client spec is used

Created: 23/Feb/07 10:05 AM Updated: 08/Aug/07 11:13 PM

Component/s:

maven-scm-provider-perforce

Affects Version/s:

1.0-beta-4

Fix Version/s:

future

Time Tracking:

Not Specified

File Attachments:

patch.p4.txt (0.6 kb)

Complexity:	Intermediate
Patch Submitted:	Yes

Description

« Hide

I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to ~~SCM-165~~, but rather the place where prop is used. Now works fine.
Patch is attached.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Mike Perham - 26/Feb/07 09:44 AM

Does Continuum have a way to set the environment variables for a build before the build is executed? If yes, you should be setting the clientspec system property to the proper value for each build beforehand. That patch is unacceptable because it removes the ability to specify the clientspec as a system property.

[ Permlink | « Hide ]

Anton Katernoga - 27/Feb/07 03:45 AM

The purpose of ~~SCM-165~~ isn't very clear to me, but from the comments I see it was necessary for several commands to run with same persistent client spec. Why do you save this specname in property although you can simply re-generate it from repo and workDir each time and it will be the same name?

[ Permlink | « Hide ]

Mike Perham - 27/Feb/07 08:30 AM

Because some corporations have naming standards for clientspecs so the clientspec name cannot be pregenerated or determined beforehand.

[ Permlink | « Hide ]

Emmanuel Venisse - 27/Feb/07 10:18 AM

I removed the maven.scm.perforce.clientspec.name system property in continuum so the correct clientspec name used should be ok now.
Anton, can you test it?

[ Permlink | « Hide ]

Emmanuel Venisse - 12/Mar/07 05:38 AM

Anton, do you have any news?

[ Permlink | « Hide ]

Sebastian Annies - 19/May/07 09:34 AM

The client spec seems to be a major problem with the perforce integration. I propose to use the P4CONFIG mechanism (or a mechanism similar to it).

1. the perforce commands should watch out for a file named .p4clientspec (just as an example) in the directory they are working in
2. if the file exists, read it and use its content as client name.
3. if a client is created by checkout command this file has to be written

What do you think?