History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SCM-215
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Emmanuel Venisse
Reporter: Richard van der Hoff
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Maven SCM

Add ability to sanitise tag names

Created: 19/Jun/06 11:37 AM   Updated: 23/Jun/06 03:57 AM
Component/s: maven-scm-api
Affects Version/s: 1.0-beta-3
Fix Version/s: 1.0-beta-4

Time Tracking:
Not Specified

File Attachments: 1. File maven-scm-tag-sanitation-tests.pach (3 kb)
2. Text File maven-scm-tag-sanitation.patch (4 kb)


Complexity: Intermediate


 Description  « Hide
In order to fix MRELEASE-110, the scm provider needs to provide a means of turning a potential tag into a valid one.

This patch adds a method to the provider API to allow this; it also provides a suitable implementation for the cvs provider.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Emmanuel Venisse - 19/Jun/06 02:31 PM
Can you add some tests?
Thanks.

Richard van der Hoff - 20/Jun/06 09:15 AM
Hrm, could do. The main reason I didn't is that I couldn't see where to fit them in. Any suggestions?

Emmanuel Venisse - 20/Jun/06 09:27 AM
you can put them in maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/main/test/org/apache/maven/scm/provider/cvslib/AbstractCvsScmProviderTest.java

Richard van der Hoff - 20/Jun/06 10:26 AM
Here are some tests for the AbstractCvsScmProvider.

Emmanuel Venisse - 23/Jun/06 03:57 AM
Applied. Thanks.