Unit Tests for org.jikesrvm.util

Here's my feedback after a quick look at the patch:

• The patch does not conform to our Checkstyle rules. Checkstyle is only run during test-runs by default. Please run it manually with ant checkstyle before creating a patch. You can set up Eclipse to help you comply with Checkstyle rules by following the instructions on the wiki in the section "Setup for easier compliance with the Checkstyle rules".

• The tests look ok, but not all implemented methods are covered. Is that intentional? If you want to determine code coverage, you can use EclEmma or something similar.

• The new implementation of hasPrevious could be written more succinctly as return cursor != null && cursor != l.head;

Fixed checkstyle issues and hasPrevious.

Updated tests to JUnit 4.10

Forgot to mention that "tests.patch" applies to a project with JUnit 4.2 and "tests-4.10.patch" applies to JUnit 4.10, so if JUnit is updated to 4.10 the second path will be the valid one, otherwise the first will be the one used (JUnit 4.2). Update to 4.10 RVM-975.

It would be nice if we could apply this patch but the tests provided in the "tests-4.10.patch" do not compile on hg tip. The compiler cannot find org.hamcrest.Matchers. Moreover, the capitalization of the test methods in StringUtilitiesTest is inconsistent with those in the other tests. For example, teststringToBytes should be named testStringToBytes.

Please provide an updated patch.

Ok I added mockito, updated the tests and separated the fix from the tests. Now that JUnit update to 4.10 was merged, I deleted the old tests (4.2), no point in having them there.

Also I've created a new class TestingTools, it helps making tests more readable and therefore, the test classes will only have nothing but test methods.

IMHO the patches can be merged if the missing license header is added to the class TestingTools.

Ok, sorry for any inconveniences, fixed it now:

[echo] Checkstyle Results
[echo] ==================
[echo]
[echo] Found 0 errors in 0 of 1382 files.

applied patches in 10474:caa8412b748a and 10475:186665f5c2d3.

Nice job. Sorry for the delay; got behind on my email due to some vacation time.

bulk close of all resolved issues in preparation for 3.1.3 release.