RVM
  1. RVM
  2. RVM-934

Process @SysCallTemplate with Java 6 Annotations API instead of APT

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.2
    • Component/s: Infrastructure: Build
    • Labels:
      None
    • Number of attachments :
      1

      Description

      The build process currently uses apt, the annotation processing tool, to process @SysCallTemplate annotations. apt is deprecated in Java 7. It is replaced
      by javac and the Java 6 APIs javax.annotation.prcessing and javax.lang.model .

      This was discussed on the mailing list and it was decided that annotations should be processed via the Java 6 API. Consequently, the Jikes RVM will require a Java 6 JDK instead of a Java 5 JDK to build.

        Activity

        Hide
        Erik Brangs added a comment -

        Here is a first attempt at a patch. Constructive critism is welcome.

        Show
        Erik Brangs added a comment - Here is a first attempt at a patch. Constructive critism is welcome.
        Hide
        Erik Brangs added a comment -

        I've also got some black-box-tests for the new annotation processing. I've not provided them because I'm not sure how they would fit in the existing test infrastructure:

        • the tests validate only the output of the annotation processing
        • the tests use JUnit but they are not unit tests
        • the tests do not need a Jikes RVM configuration

        They're also badly written. I'd be willing to rework them to fit the test infrastructure if there's a consensus on how they should be integrated.

        Show
        Erik Brangs added a comment - I've also got some black-box-tests for the new annotation processing. I've not provided them because I'm not sure how they would fit in the existing test infrastructure: the tests validate only the output of the annotation processing the tests use JUnit but they are not unit tests the tests do not need a Jikes RVM configuration They're also badly written. I'd be willing to rework them to fit the test infrastructure if there's a consensus on how they should be integrated.
        Hide
        David Grove added a comment -

        committed patch in 10402-10404.

        Added note in NEWS; updated Userguide wiki page to list Java 6 instead of Java 5 as needed to build Jikes RVM.

        Show
        David Grove added a comment - committed patch in 10402-10404. Added note in NEWS; updated Userguide wiki page to list Java 6 instead of Java 5 as needed to build Jikes RVM.

          People

          • Assignee:
            David Grove
            Reporter:
            Erik Brangs
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: