RVM

A url for checkstyle 4.3 does not exist.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.1.1
  • Fix Version/s: 3.1.2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    3

Description

Hi, all.

I tried to build jikesrvm-3.1.1.
I failed in build. I think a url of checkstyle-4.3 does not exist.

...
init-checkstyle-properties:

fetch:
[mkdir] Created dir: /home/nari/source/jikesrvm/components/checkstyle/4.3
[echo] Downloading (no cache available)
[get] Getting: http://optusnet.dl.sourceforge.net/sourceforge/checkstyle/checkstyle-4.3.tar.gz
[get] To: /home/nari/source/jikesrvm/components/checkstyle/4.3/checkstyle-4.3.tar.gz
[get] Error opening connection java.io.FileNotFoundException: http://optusnet.dl.sourceforge.net/sourceforge/checkstyle/checkstyle-4.3.tar.gz
[get] Error opening connection java.io.FileNotFoundException: http://optusnet.dl.sourceforge.net/sourceforge/checkstyle/checkstyle-4.3.tar.gz
[get] Error opening connection java.io.FileNotFoundException: http://optusnet.dl.sourceforge.net/sourceforge/checkstyle/checkstyle-4.3.tar.gz
[get] Can't get http://optusnet.dl.sourceforge.net/sourceforge/checkstyle/checkstyle-4.3.tar.gz to /home/nari/source/jikesrvm/components/checkstyle/4.3/checkstyle-4.3.tar.gz

BUILD FAILED
/home/nari/source/jikesrvm/build.xml:270: The following error occurred while executing this line:
/home/nari/source/jikesrvm/build/components/checkstyle.xml:50: The following error occurred while executing this line:
/home/nari/source/jikesrvm/build/components/base.xml:70: The following error occurred while executing this line:
/home/nari/source/jikesrvm/build/components/base.xml:76: The following error occurred while executing this line:
/home/nari/source/jikesrvm/build/components/checkstyle.xml:40: The following error occurred while executing this line:
/home/nari/source/jikesrvm/build/components/base.xml:110: The following error occurred while executing this line:
/home/nari/source/jikesrvm/build/components/base.xml:118: Can't get http://optusnet.dl.sourceforge.net/sourceforge/checkstyle/checkstyle-4.3.tar.gz to /home/nari/source/jikesrvm/components/checkstyle/4.3/checkstyle-4.3.tar.gz
..

Thanks.

  1. File
    bandaid-fix-for-RVM917.diff
    09/Apr/11 6:38 AM
    2 kB
    Erik Brangs
  2. File
    checkstyle-update-for-RVM-917.diff
    04/May/11 10:23 AM
    5 kB
    Erik Brangs
  3. File
    CheckStyleUrlFix.diff
    04/May/11 11:16 PM
    0.8 kB
    Michael Taylor

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Erik Brangs added a comment -

As you suspected, the URL no longer exists.

Checkstyle is only needed for checking source files prior to commiting (see http://jira.codehaus.org/browse/RVM-300 ). Checkstyle 4.3 is more than 3 years old. It is not available on checkstyle.sourceforge.net anymore.

There are 3 possibilities:
a) Disable checkstyle (bad if you want to contribute patches)
b) Use the provided patch to update the checkstyle version (untested)
c) Get checkstyle 4.3 from some other place and update the URL accordingly. I have not tried this.

a) You can comment out the line

<ant antfile="build/components/checkstyle.xml" target="ensure"/>

in build.xml in the "check-components-properties" target as a workaround. However, this means that you will not be able to run tests that require checkstyle (e.g. the pre-commit test run). You can create modified test-runs by creating appropriate .properties files in build/test-runs.

b) Use the provided patch to update the checkstyle version to 4.4. The newest version of checkstyle is 5.3 but there were some changes in 5.0 that might break backwards compatibility. I am not familiar with checkstyle and I am not a member of the development team, so I do not know if this breaks something. I can only say that building and running the pre-commit test run succeeds.

Show
Erik Brangs added a comment - As you suspected, the URL no longer exists. Checkstyle is only needed for checking source files prior to commiting (see http://jira.codehaus.org/browse/RVM-300 ). Checkstyle 4.3 is more than 3 years old. It is not available on checkstyle.sourceforge.net anymore. There are 3 possibilities: a) Disable checkstyle (bad if you want to contribute patches) b) Use the provided patch to update the checkstyle version (untested) c) Get checkstyle 4.3 from some other place and update the URL accordingly. I have not tried this. a) You can comment out the line <ant antfile= "build/components/checkstyle.xml" target= "ensure" /> in build.xml in the "check-components-properties" target as a workaround. However, this means that you will not be able to run tests that require checkstyle (e.g. the pre-commit test run). You can create modified test-runs by creating appropriate .properties files in build/test-runs. b) Use the provided patch to update the checkstyle version to 4.4. The newest version of checkstyle is 5.3 but there were some changes in 5.0 that might break backwards compatibility. I am not familiar with checkstyle and I am not a member of the development team, so I do not know if this breaks something. I can only say that building and running the pre-commit test run succeeds.
Hide
Permalink
Narihiro Nakamura added a comment -

Thank you for your detail comment.
My problem was settled.

Show
Narihiro Nakamura added a comment - Thank you for your detail comment. My problem was settled.
Hide
Permalink
Erik Brangs added a comment -

The attached patch (checkstyle-update-...) updates the Checkstyle version to 5.3 but does not add any checks. It is probably a good idea to evaluate if any of the checks added between Checkstyle 4.3 and 5.3 are useful for the RVM.

Show
Erik Brangs added a comment - The attached patch (checkstyle-update-...) updates the Checkstyle version to 5.3 but does not add any checks. It is probably a good idea to evaluate if any of the checks added between Checkstyle 4.3 and 5.3 are useful for the RVM.
Hide
Permalink
Michael Taylor added a comment -

The attached patch CheckStyleUrlFix changes the url and keeps the checkstyle version the same

Show
Michael Taylor added a comment - The attached patch CheckStyleUrlFix changes the url and keeps the checkstyle version the same
Hide
Permalink
David Grove added a comment -

applied patch to upgrade to 5.3 in 10387:13f5ec8efaf1.

Show
David Grove added a comment - applied patch to upgrade to 5.3 in 10387:13f5ec8efaf1.
Hide
Permalink
David Grove added a comment -

bulk close of all resolved issues in preparation for 3.1.3 release.

Show
David Grove added a comment - bulk close of all resolved issues in preparation for 3.1.3 release.

People

  • Assignee:
    David Grove
    Reporter:
    Narihiro Nakamura
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: