Details
Description
when BYTES_IN_COPY == 8 then aligned32Copy in org.jikesrvm.runtime.Memory can incorrectly copy 8 bytes (4bytes + 4 bytes) when src is 4 byte aligned. The attached patch adds a series of assertions that verify the assumptions described in the Javadoc and an explicit check for if numBytes == 0
Activity
Laurence Hellyer
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | RVM-900.patch [ 51612 ] |
Daniel Frampton
made changes -
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
David Grove
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
As noted by Daniel there is a commented out call to aligned32Copy at line 319 in Memory.java, uncommenting this call and removing the rest of this method passes the pre-commit tests but more validation (and probably an entire regression run) is needed.