RVM
  1. RVM
  2. RVM-900

aligned32Copy can copy 8 bytes when number of bytes to copy is 0

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.1.2
    • Component/s: Runtime
    • Labels:
      None
    • Environment:
      ia32 with SSE2 enabled
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      when BYTES_IN_COPY == 8 then aligned32Copy in org.jikesrvm.runtime.Memory can incorrectly copy 8 bytes (4bytes + 4 bytes) when src is 4 byte aligned. The attached patch adds a series of assertions that verify the assumptions described in the Javadoc and an explicit check for if numBytes == 0

        Activity

        Laurence Hellyer made changes -
        Field Original Value New Value
        Attachment RVM-900.patch [ 51612 ]
        Hide
        Laurence Hellyer added a comment -

        As noted by Daniel there is a commented out call to aligned32Copy at line 319 in Memory.java, uncommenting this call and removing the rest of this method passes the pre-commit tests but more validation (and probably an entire regression run) is needed.

        Show
        Laurence Hellyer added a comment - As noted by Daniel there is a commented out call to aligned32Copy at line 319 in Memory.java, uncommenting this call and removing the rest of this method passes the pre-commit tests but more validation (and probably an entire regression run) is needed.
        Hide
        Daniel Frampton added a comment -

        Commited fix in r16017.

        Show
        Daniel Frampton added a comment - Commited fix in r16017.
        Daniel Frampton made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        David Grove added a comment -

        bulk close of all resolved issues in preparation for 3.1.3 release.

        Show
        David Grove added a comment - bulk close of all resolved issues in preparation for 3.1.3 release.
        David Grove made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Daniel Frampton
            Reporter:
            Laurence Hellyer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: