Outline exception raising code in gnu.java.lang.CPStringBuilder to enable better inlining

Details

Description

See parent task for discussion; creating JIRA item to associate with path against GNU classpath.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Grove added a comment -

patch committed in r15432.

Show
David Grove added a comment - patch committed in r15432.
Hide
Permalink
David Grove added a comment -

initially appears to have helped by a few percent, but not a real significant gain for luindex. Have to look some more, but my assumption is that we're going to have to do some more restructuring to get enough inlining happening to enable scalar replacement in the key methods.

Show
David Grove added a comment - initially appears to have helped by a few percent, but not a real significant gain for luindex. Have to look some more, but my assumption is that we're going to have to do some more restructuring to get enough inlining happening to enable scalar replacement in the key methods.
Hide
Permalink
Ian Rogers added a comment -

Can you force the inlining using the AnnotationAdder ?

Show
Ian Rogers added a comment - Can you force the inlining using the AnnotationAdder ?
Hide
Permalink
David Grove added a comment -

If my WAG that it's missing inlining that is killing us is right, then yes the AnnotationAdder is a possibility to fix that.

I need to do some more digging to determine exactly what is going on.

Show
David Grove added a comment - If my WAG that it's missing inlining that is killing us is right, then yes the AnnotationAdder is a possibility to fix that. I need to do some more digging to determine exactly what is going on.

People

  • Assignee:
    David Grove
    Reporter:
    David Grove
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: