RVM
  1. RVM
  2. RVM-756

Intel unnecessarily restricts boot image to be at addresses > 0x30000000

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.0
    • Component/s: Runtime
    • Labels:
      None
    • Number of attachments :
      0

      Description

      In the Intel libvm.c we do:

      unsigned int vp_hn; /* the high nibble of the vp address value */
      vp_hn = localVirtualProcessorAddress >> 28;
      if (vp_hn < 3 || !inRVMAddressSpace(localVirtualProcessorAddress))

      that asserts that the high nibble of objects must be above 0x30000000 making it impossible to fully use the heap. The high nibble tests should be removed.

        Activity

        Hide
        David Grove added a comment -

        I think the nibble based assertion is older than inRVMAddressSpace (ie, it predates the inRVMAddressSpace function being available).

        I don't object to removing it.

        For the truly paranoid, we could add an extra debugging test that the value in the TIB slot of *localVPA is equal to the TIB of the Processor class.

        Show
        David Grove added a comment - I think the nibble based assertion is older than inRVMAddressSpace (ie, it predates the inRVMAddressSpace function being available). I don't object to removing it. For the truly paranoid, we could add an extra debugging test that the value in the TIB slot of *localVPA is equal to the TIB of the Processor class.
        Hide
        Ian Rogers added a comment -

        Fix in r15319.

        Show
        Ian Rogers added a comment - Fix in r15319.
        Ian Rogers made changes -
        Field Original Value New Value
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]

          People

          • Assignee:
            Ian Rogers
            Reporter:
            Ian Rogers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: