[#RVM-612] Assertion checking on stack height in baseline compiler

RVM

Assertion checking on stack height in baseline compiler

Created: 06/Aug/08 02:26 PM Updated: 04/Nov/08 06:49 PM

Component/s:

Compiler: Baseline, Instruction Architecture: PowerPC

Affects Version/s:

None

Fix Version/s:

3.0.2

Time Tracking:

Issue & Sub-Tasks

Issue Only

Not Specified

Sub-Tasks:

All

Open

~~i2f sequence in PPC-64 baseline compiler overflows expression stack~~

Closed

David Grove

Description

« Hide

Add checking to pushXXX methods in baseline compiler to check that we never push beyond the limits of the Java expression stack. (root cause of ~~RVM-550~~).

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

David Grove added a comment - 06/Aug/08 02:42 PM - edited

Note: only applicable to ppc baseline compiler because it allocates space for expression stack within the frame. On IA32 expression stack is at the "end" of the stackframe, so there is nothing to get smashed by pushes...

[ Permlink | « Hide ]

David Grove added a comment - 15/Oct/08 08:22 AM

Prototyped, but either not quite right yet or exposing a bug in jython/OSR handling. So deferring to 3.0.2.

[ Permlink | « Hide ]

David Grove added a comment - 04/Nov/08 06:49 PM

committed in r15142.