RVM

Inline checkcast/instanceof sequences in baseline compiler for simple cases

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.0
  • Component/s: Compiler: Baseline
  • Labels:
    None
  • Number of attachments :
    0

Description

We should generate inline code sequences for the most common cases of dynamic type checking in the baseline compilers implementation of instanceof/checkcast. In particular, if the LHS type is a resolved proper class or interface the inline sequence is actually smaller and easier to generate than the call to the out-of-line routines we are using now.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Grove added a comment -

Based on the profiles I'm seeing for bloat after r14522, it appears there's an additional 25-35% speedup of prototype images on ppc64-aix running bloat to be had by implementing this feature. That should be enough to get bloat to not time out on nightly ppc regression tests and should have some impact on production performance, at least on initial iteration.

Show
David Grove added a comment - Based on the profiles I'm seeing for bloat after r14522, it appears there's an additional 25-35% speedup of prototype images on ppc64-aix running bloat to be had by implementing this feature. That should be enough to get bloat to not time out on nightly ppc regression tests and should have some impact on production performance, at least on initial iteration.
Hide
Permalink
David Grove added a comment -

r14526 implemented an inline sequence for checkcast of a resolved interface to the baseline compilers.

This was the key case for the bloat running on a prototype image; bloat now runs in 550 seconds on excalibur.

Show
David Grove added a comment - r14526 implemented an inline sequence for checkcast of a resolved interface to the baseline compilers. This was the key case for the bloat running on a prototype image; bloat now runs in 550 seconds on excalibur.
Hide
Permalink
David Grove added a comment -

r14528 implemented inline sequence for checkcast for final types.

Show
David Grove added a comment - r14528 implemented inline sequence for checkcast for final types.
Hide
Permalink
David Grove added a comment -

r14541 added inline sequences for checkcast of a resolved, non-final class.

Show
David Grove added a comment - r14541 added inline sequences for checkcast of a resolved, non-final class.
Hide
Permalink
David Grove added a comment -

r14554 added instanceof final and resolved classes to ia32 baseline compiler.

Show
David Grove added a comment - r14554 added instanceof final and resolved classes to ia32 baseline compiler.
Hide
Permalink
David Grove added a comment -

instanceof interface completed in r14605.

Show
David Grove added a comment - instanceof interface completed in r14605.
Hide
Permalink
David Grove added a comment -

reopening so I can modify fix target to 3.0

Show
David Grove added a comment - reopening so I can modify fix target to 3.0

People

  • Assignee:
    David Grove
    Reporter:
    David Grove
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: