RVM

Rename classes currently with VM_ prefix that will be confusing without it

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.0
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Before doing a bulk removal of the VM_ prefix, there are a bunch of classes that should be individually renamed to avoid clashing/confusion when the VM_ removal happens.

Here's my initial list. I think the way to handle this is to knock them off in a series of smaller steps; possibly we could parallelize this. I think my default proposal would be to make many of them by RVMFoo (eg RVMHashMap), in some cases leaving a VM prefix (but not VM_) could be the right thing to do.

Likely clashes with java.* classes in lang/util/reflect/etc

./org/jikesrvm/classloader/VM_Annotation.java
./org/jikesrvm/classloader/VM_Class.java
./org/jikesrvm/classloader/VM_Field.java
./org/jikesrvm/classloader/VM_Method.java
./org/jikesrvm/classloader/VM_ClassLoader.java
./org/jikesrvm/classloader/VM_BootstrapClassLoader.java
./org/jikesrvm/classloader/VM_Member.java
./org/jikesrvm/classloader/VM_Array.java
./org/jikesrvm/runtime/VM_Math.java
./org/jikesrvm/runtime/VM_Runtime.java
./org/jikesrvm/scheduler/VM_FinalizerThread.java
./org/jikesrvm/scheduler/VM_Thread.java
./org/jikesrvm/util/VM_PriorityQueue.java
./org/jikesrvm/util/VM_IdentityHashMap.java
./org/jikesrvm/util/VM_HashMap.java
./org/jikesrvm/util/VM_AbstractHashMap.java
./org/jikesrvm/util/VM_AbstractHashSet.java
./org/jikesrvm/util/VM_ImmutableEntryHashSet.java
./org/jikesrvm/util/VM_LinkedList.java
./org/jikesrvm/util/VM_LinkedListIterator.java
./org/jikesrvm/util/VM_BitVector.java
./org/jikesrvm/util/VM_ImmutableEntryHashMap.java
./org/jikesrvm/util/VM_AddressInputStream.java
./org/jikesrvm/util/VM_Synchronizer.java
./org/jikesrvm/util/VM_HashSet.java
./org/jikesrvm/util/VM_ImmutableEntryIdentityHashMap.java
./org/jikesrvm/runtime/VM_StackTrace.java
./org/jikesrvm/VM_UnimplementedError.java
./org/jikesrvm/scheduler/greenthreads/VM_Process.java
./org/jikesrvm/VM_Properties.java

Likely to clash/confuse with internal names so should be renamed
./org/jikesrvm/options/VM_OptionSet.java
./org/jikesrvm/runtime/VM_Memory.java
./org/jikesrvm/compilers/baseline/ia32/VM_Compiler.java
./org/jikesrvm/VM_Constants.java
./org/jikesrvm/classloader/VM_Type.java
./org/jikesrvm/ia32/VM_Registers.java

Special handling (magic)
./org/jikesrvm/ia32/VM_CodeArray.java

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Christoph Bockisch added a comment -

Just for the purpose of discussion: I think suffixes could be better than prefixes. The current "VM_" prefix is annoying when you use content assist in the IDE. So, what about "HashMapRVM". Maybe it doesn't really look right ... but it's practical.

Show
Christoph Bockisch added a comment - Just for the purpose of discussion: I think suffixes could be better than prefixes. The current "VM_" prefix is annoying when you use content assist in the IDE. So, what about "HashMapRVM". Maybe it doesn't really look right ... but it's practical.
Hide
Permalink
David Grove added a comment -

Current list of classes to deal with is down to:

./org/jikesrvm/classloader/VM_Annotation.java
./org/jikesrvm/classloader/VM_Class.java
./org/jikesrvm/classloader/VM_Field.java
./org/jikesrvm/classloader/VM_Method.java
./org/jikesrvm/classloader/VM_ClassLoader.java
./org/jikesrvm/classloader/VM_Member.java
./org/jikesrvm/classloader/VM_Array.java
./org/jikesrvm/classloader/VM_Type.java
./org/jikesrvm/scheduler/greenthreads/VM_Process.java
./org/jikesrvm/VM_Properties.java

./org/jikesrvm/runtime/VM_StackTrace.java

With the possibly exception of VM_StackTrace, I propose to rename all of these to RVMFoo (VM_Foo ==> RVMFoo).
I have to look at VM_StackTrace and see if it would be acceptable to have a name clash with StackTrace or VMStackTrace.

After these last renames are complete, I plan to continue with the VM_ renaming farily quickly.

Show
David Grove added a comment - Current list of classes to deal with is down to: ./org/jikesrvm/classloader/VM_Annotation.java ./org/jikesrvm/classloader/VM_Class.java ./org/jikesrvm/classloader/VM_Field.java ./org/jikesrvm/classloader/VM_Method.java ./org/jikesrvm/classloader/VM_ClassLoader.java ./org/jikesrvm/classloader/VM_Member.java ./org/jikesrvm/classloader/VM_Array.java ./org/jikesrvm/classloader/VM_Type.java ./org/jikesrvm/scheduler/greenthreads/VM_Process.java ./org/jikesrvm/VM_Properties.java ./org/jikesrvm/runtime/VM_StackTrace.java With the possibly exception of VM_StackTrace, I propose to rename all of these to RVMFoo (VM_Foo ==> RVMFoo). I have to look at VM_StackTrace and see if it would be acceptable to have a name clash with StackTrace or VMStackTrace. After these last renames are complete, I plan to continue with the VM_ renaming farily quickly.
Hide
Permalink
David Grove added a comment -

Committed in a number of steps over the last two weeks. Final commit was r14504.

Show
David Grove added a comment - Committed in a number of steps over the last two weeks. Final commit was r14504.
Hide
Permalink
David Grove added a comment -

reopening so I can modify fix target to 3.0

Show
David Grove added a comment - reopening so I can modify fix target to 3.0

People

  • Assignee:
    David Grove
    Reporter:
    David Grove
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: