RVM

Conversion between type descriptors, class names, and file names in VM_Atom behaves inconsistently

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.9.3
  • Fix Version/s: 3.0
  • Component/s: None
  • Labels:
    None
  • Environment:
    prototype Jikes RVM 2.9.3+svn (r14214) using GNU Classpath 0.97.1
  • Number of attachments :
    0

Description

In VM_Atom there is a bug in classFileNameFromDescriptor: the method shouldn't replace slashes with dots. At any rate, this is currently not an issue as classFileNameFromDescriptor is never called; either fix it or remove it.

On a related note, descriptorFromClassName's code and comment are inconsistent with classNameFromDescriptor's; in the latter case a class name uses dots as separators, whereas in the former case it uses slashes. (FWIW, I deem classNameFromDescriptor's interpretation correct.)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ian Rogers added a comment -

Sounds like you have a patch, do you want to post it (with a contributors statement [1]) and we can review it? Thanks!

[1] http://jikesrvm.org/Contributions

Show
Ian Rogers added a comment - Sounds like you have a patch, do you want to post it (with a contributors statement [1] ) and we can review it? Thanks! [1] http://jikesrvm.org/Contributions
Hide
Permalink
Andreas Sewe added a comment -

No, I don't have a patch; I just stumbled upon these two methods while tracking down RVM-493.

Now removing classFileNameFromDescriptor would be trivial, but I am still left wondering why it isn't used. Seems like a useful convenience method during classloading to me. But that's a question only you guys can answer.

As for descriptorFromClassName and classNameFromDescriptor, I am hesitant to fix anything, because nothing is broken in the sense that I have a test failing here. It is just that this is IMHO an issue that needs to be looked into – even if it is resolved by just renaming descriptorFromClassName into something consistent with the general Java/JVM terminology.

Show
Andreas Sewe added a comment - No, I don't have a patch; I just stumbled upon these two methods while tracking down RVM-493 . Now removing classFileNameFromDescriptor would be trivial, but I am still left wondering why it isn't used. Seems like a useful convenience method during classloading to me. But that's a question only you guys can answer. As for descriptorFromClassName and classNameFromDescriptor , I am hesitant to fix anything, because nothing is broken in the sense that I have a test failing here. It is just that this is IMHO an issue that needs to be looked into – even if it is resolved by just renaming descriptorFromClassName into something consistent with the general Java/JVM terminology.
Hide
Permalink
Ian Rogers added a comment -

Patched in r14730.

Show
Ian Rogers added a comment - Patched in r14730.

People

  • Assignee:
    Ian Rogers
    Reporter:
    Andreas Sewe
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: