jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • RVM
  • RVM-471

Stack frame alignment broken for Intel on OS/X

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: None
  • Fix Version/s: 3.0.1
  • Component/s: Instruction Architecture: Intel, Operating System: OSX
  • Labels:
    None

Description

OS/X on Intel requires 16byte stack alignment. We keep the stack aligned to 4 bytes.

For the baseline compiler we should:

  • before pushing parameters for a call generate alignment operations (either extra push/pop operations or adds to the stack pointer)
  • the amount required to align the stack is calculated from the number of locals, the height of the stack (we maintain this in an array for the Intel baseline compiler) and the number of parameters.

For the opt compiler we again need to generate extra alignment in the opt stack manager

For the JNI compiler we need to ensure alignment on going to JNI code and when entering from JNI code we need to make sure we maintain alignment.

A number of source forge trackers have tracked this previously a provide incomplete patches or inadmissible patches that change the intel compilers to performing explicit masks on the stack pointer. Here are the trackers:

RVM-465 - tracked a bug when compiling on newer Intel OS/X

SF 1693226 - a patch from April 2007 that tries to force stack alignment using masks. Incomplete and isn't conditionally compiled.
http://sourceforge.net/tracker/index.php?func=detail&aid=1693226&group_id=128805&atid=712770

SF 1691503 - again from April 2007, the associated patch is deleted. It did try to align the JNI stack. There are various comments about other build problems on Intel OS/X that weren't present by the resolution of RVM-465
http://sourceforge.net/tracker/index.php?func=detail&aid=1691503&group_id=128805&atid=712768

Issue Links

is superceded by

Bug - A problem which impairs or prevents the functions of the product. RVM-652 build failure on IA32 OS X 10.5 (Leopard)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
supercedes

Bug - A problem which impairs or prevents the functions of the product. RVM-465 Build problems on IA32 OS/X

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Ian Rogers added a comment - 01/May/08 9:50 AM - edited

This supercedes patch:
http://sourceforge.net/tracker/index.php?func=detail&aid=1693226&group_id=128805&atid=712770
and RFE:
http://sourceforge.net/tracker/index.php?func=detail&aid=1691503&group_id=128805&atid=712768

Show
Ian Rogers added a comment - 01/May/08 9:50 AM - edited This supercedes patch: http://sourceforge.net/tracker/index.php?func=detail&aid=1693226&group_id=128805&atid=712770 and RFE: http://sourceforge.net/tracker/index.php?func=detail&aid=1691503&group_id=128805&atid=712768
Hide
Permalink
Ian Rogers added a comment - 16/Sep/08 2:11 PM

RVM-652 fixed this issue.

Show
Ian Rogers added a comment - 16/Sep/08 2:11 PM RVM-652 fixed this issue.

People

  • Assignee:
    Ian Rogers
    Reporter:
    Ian Rogers
Vote (0)
Watch (0)

Dates

  • Created:
    30/Apr/08 4:00 PM
    Updated:
    16/Sep/08 2:11 PM
    Resolved:
    16/Sep/08 2:11 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.