Fix IA32 assembler to use Address instead of Offset for absolute addressing

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.9.2
  • Fix Version/s: 3.0
  • Component/s: Instruction Architecture: Intel
  • Labels:
    None
  • Environment:
    IA32
  • Patch Submitted:
    Yes

Description

Related to RVM-445. Fix the assembler used by both compilers on IA32 to take org.vmmagic.unboxed.Address instead of org.vmmagic.unboxed.Offset when using absolute addressing modes. Currently, the system doesn't use this except in the opt compiler, which ends up using Offset as a catch-all type for pointer-sized words used in specifying addresses (be they actual offsets or absolutes). But - this change is essential to enable non-kludgey use of absolute addressing in future changes (such as the JTOC fix in RVM-445).

  1. Text File
    fix_ia32_asm.patch
    29/Apr/08 9:44 PM
    17 kB
    Filip Pizlo
  2. Text File
    soo.txt
    14/May/08 4:52 PM
    0.5 kB
    Filip Pizlo

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Filip Pizlo added a comment -

Note: this has been tested and seems to not break IA32 under both opt and baseline. Also tested PPC as a sanity check.

Show
Filip Pizlo added a comment - Note: this has been tested and seems to not break IA32 under both opt and baseline. Also tested PPC as a sanity check.
Hide
Permalink
David Grove added a comment -

Patch commited in r14226.

Show
David Grove added a comment - Patch commited in r14226.
Hide
Permalink
David Grove added a comment -

reopening so I can modify fix target to 3.0

Show
David Grove added a comment - reopening so I can modify fix target to 3.0

People

  • Assignee:
    David Grove
    Reporter:
    Filip Pizlo
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: