jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • RVM
  • RVM-451

Structure of code in GNU Classpath java.util.Vector and java.util.Arraylist interacts poorly with inlining

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.9.3
  • Component/s: Runtime: Class Library
  • Labels:
    None

Description

The checkBoundExclusive and checkBoundInclusive helper methods of these classes are poorly designed for use with Jikes RVM's opt compiler. Because we don't do partial method inlniing, we either don't inline the bounds check (bad idea) or we do inline the bounds check and also inline the various String Builder operations, exception allocation, and throw. I'm testing a patch that corrects this using our usual pattern of pushing the exceptional code out into a helper method. Opening the JIRA item so I can have a number to use to name the patch in our build process...

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    classpath-cvs.RVM-451.patch
    23/Apr/08 10:52 AM
    3 kB
    David Grove

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. RVM-446 Investigate performance regression in Compress

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
David Grove added a comment - 23/Apr/08 10:54 AM

Moving to resolved (but not closed). Patch committed on the RVM side in r14151.

Show
David Grove added a comment - 23/Apr/08 10:54 AM Moving to resolved (but not closed). Patch committed on the RVM side in r14151.
Hide
Permalink
Ian Rogers added a comment - 26/Apr/08 11:54 AM

Patch applied to Classpath.

Show
Ian Rogers added a comment - 26/Apr/08 11:54 AM Patch applied to Classpath.

People

  • Assignee:
    Ian Rogers
    Reporter:
    David Grove
Vote (0)
Watch (0)

Dates

  • Created:
    23/Apr/08 9:22 AM
    Updated:
    26/Apr/08 11:54 AM
    Resolved:
    23/Apr/08 10:54 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.