[#RVM-379] Don't replicate OSR_EncodedOSRMaps

RVM

Don't replicate OSR_EncodedOSRMaps

Created: 23/Feb/08 08:43 AM Updated: 11/Mar/08 06:54 AM

Component/s:

Compiler: Optimizing, Runtime

Affects Version/s:

None

Fix Version/s:

2.9.3

Time Tracking:

Not Specified

File Attachments:

OSR_EncodedOSRMap.patch (4 kB)

Description

« Hide

This patch adds a map to avoid replicating OSR maps and passes pre-commit tests (I'm not claiming its sane). The patch reduces 19523 objects of size 546644bytes to 1 object of size 28bytes in the boot image (hence my worrying about its sanity). With the other objects hanging off OSR_EncodedOSRMap this represents a significant saving, if we can conclude the patch is sane.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

David Grove added a comment - 23/Feb/08 02:47 PM

My WAG would be that this is telling us that we should probably have a special case for OSR_EncodedOSRMap which says "no information". I have a vague recollection that we disable OSR-guarded inlining for bootimage code (because some parts of the bootimage are sensitive and we can't do an OSR while executing them), so all of these maps in the bootimage are probably empty.

[ Permlink | « Hide ]

Ian Rogers added a comment - 24/Feb/08 07:46 AM

I agree, how can we reduce the boot image space?

[ Permlink | « Hide ]

Ian Rogers added a comment - 07/Mar/08 04:12 PM

Committed variant in r14008 as the empty map is by far the most common, this avoids the use of a hash map.