RVM
  1. RVM
  2. RVM-364

ant real-clean doesn't clean up fully

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.2
    • Component/s: Infrastructure: Build
    • Labels:
      None
    • Number of attachments :
      1

      Description

      With ant real-clean being the strongest clean target, I'd expect it to give me a clean workspace. Not so. Notably the components/components.properties file remains as does the Classpath build tree. This just stopped me building because the paths in components.properties have changed.

      This is with my branch. I'll check it on trunk as well soon.

        Activity

        Hide
        Andrew John Hughes added a comment -

        Building trunk and then deleting components/components.properties gives:

        BUILD FAILED
        /home/andrew/projects/java/classpath/jikesrvm/build.xml:228: The following error occurred while executing this line:
        /home/andrew/projects/java/classpath/jikesrvm/build/base.xml:98: Value of classpath.lib.dir property is invalid. ($

        {x86_64-linux.classpath.lib.dir}

        ).

        This is without a clean.

        Show
        Andrew John Hughes added a comment - Building trunk and then deleting components/components.properties gives: BUILD FAILED /home/andrew/projects/java/classpath/jikesrvm/build.xml:228: The following error occurred while executing this line: /home/andrew/projects/java/classpath/jikesrvm/build/base.xml:98: Value of classpath.lib.dir property is invalid. ($ {x86_64-linux.classpath.lib.dir} ). This is without a clean.
        Hide
        Stephan Diestelhorst added a comment - - edited

        Bitten by this, too.

        Comparing a fresh checkout with the copied over build directory suggests that only the folders components and target differ. Deleting those should be back
        to fresh state...

        And yes, I think the build chain leaves much to be desired, when one comes from make + X.

        Show
        Stephan Diestelhorst added a comment - - edited Bitten by this, too. Comparing a fresh checkout with the copied over build directory suggests that only the folders components and target differ. Deleting those should be back to fresh state... And yes, I think the build chain leaves much to be desired, when one comes from make + X.
        Hide
        Erik Brangs added a comment -

        Here is an attempt at a patch. The patch introduces two new targets:
        1) a new clean target called cleanest that deletes the components
        2) a target called purge that deletes everything

        The patch is untested because I did not know how I could properly test it.

        Show
        Erik Brangs added a comment - Here is an attempt at a patch. The patch introduces two new targets: 1) a new clean target called cleanest that deletes the components 2) a target called purge that deletes everything The patch is untested because I did not know how I could properly test it.
        Hide
        David Grove added a comment -

        Applied Erik's patch in 10406:fd9c1d08fa64.

        Show
        David Grove added a comment - Applied Erik's patch in 10406:fd9c1d08fa64.
        Hide
        David Grove added a comment -

        bulk close of all resolved issues in preparation for 3.1.3 release.

        Show
        David Grove added a comment - bulk close of all resolved issues in preparation for 3.1.3 release.

          People

          • Assignee:
            David Grove
            Reporter:
            Andrew John Hughes
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: