RVM
  1. RVM
  2. RVM-359

Introduce two non-terminals called float_load and double_load, and impove the SSE2's add, sub, mul, div rules with the two terminals. The cost of the original add,sub,mul, div rules was changed to match the description of the BURS file.

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.3
    • Fix Version/s: None
    • Labels:
      None
    • Number of attachments :
      1

      Issue Links

        Activity

        LiGen made changes -
        Field Original Value New Value
        Attachment IA32_SSE2.patch [ 31658 ]
        Hide
        LiGen added a comment -

        Introduce two non-terminals called float_load and double_load. When these are called they save a memory operand on a stack in the BURS_Helpers, this is pulled out again in the corresponding float add/sub and double add by the call to consumeMO again from the BURS_Helpers. This makes the code a little cleaner and smaller. And thanks for Ian's kindly help.

        Show
        LiGen added a comment - Introduce two non-terminals called float_load and double_load. When these are called they save a memory operand on a stack in the BURS_Helpers, this is pulled out again in the corresponding float add/sub and double add by the call to consumeMO again from the BURS_Helpers. This makes the code a little cleaner and smaller. And thanks for Ian's kindly help.
        Hide
        Ian Rogers added a comment -

        Great work! I will look to apply the patch after next week. If someone wants to do it before me then please do. I think the only thing that is missing with your patch is a contribution statement. There's more information here: http://jikesrvm.org/Contributions . You need to copy and complete the text from here: http://docs.codehaus.org/download/attachments/74078/single-contrib.txt?version=1

        Show
        Ian Rogers added a comment - Great work! I will look to apply the patch after next week. If someone wants to do it before me then please do. I think the only thing that is missing with your patch is a contribution statement. There's more information here: http://jikesrvm.org/Contributions . You need to copy and complete the text from here: http://docs.codehaus.org/download/attachments/74078/single-contrib.txt?version=1
        Ian Rogers made changes -
        Link This issue is related to RVM-360 [ RVM-360 ]
        Hide
        LiGen added a comment -

        STATEMENT OF ORIGIN FOR A SINGLE CONTRIBUTOR

        I, LiGen:

        (a) represent that either:

        I am the only author and owner of the contributed software
        (described as/entitled "Fix BURS SSE load/store rules"),
        which was neither derived nor copied from any other software,
        or

        (ii) that any exception to is software which was obtained under the
        CPL (Common Public License),

        and

        (b) hereby agree to license this contributed software under the CPL.

        Show
        LiGen added a comment - STATEMENT OF ORIGIN FOR A SINGLE CONTRIBUTOR I, LiGen: (a) represent that either: I am the only author and owner of the contributed software (described as/entitled "Fix BURS SSE load/store rules"), which was neither derived nor copied from any other software, or (ii) that any exception to is software which was obtained under the CPL (Common Public License), and (b) hereby agree to license this contributed software under the CPL.
        Hide
        Ian Rogers added a comment -

        Patch committed in r13941.

        Show
        Ian Rogers added a comment - Patch committed in r13941.
        Ian Rogers made changes -
        Resolution Fixed [ 1 ]
        Assignee Ian Rogers [ ianrogers ]
        Status Open [ 1 ] Resolved [ 5 ]
        Ian Rogers made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Ian Rogers made changes -
        Link This issue duplicates RVM-163 [ RVM-163 ]

          People

          • Assignee:
            Ian Rogers
            Reporter:
            LiGen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: