RVM

Determine whether patching Classpath sources is preferable to bytecode engineering adding annotations

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.9.2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Currently we override the default Classpath String class with that provided in libraryInterface. This introduces pragma annotations useful for the RVM. We wish to move this process as it requires keeping a file consistent with that in the Classpath repository. One approach would be to use a patch on the source file to solve the problem. Possibly a better solution would be to use something like BCEL to insert annotations on methods in the compiled class file.

Activity

Hide
Permalink
Ian Rogers added a comment -

Using ASM (http://asm.objectweb.org/) I was able to write a program to add annotations to classes in less than 200 lines of Java. Adding annotations this way for files not within the RVM seems preferable to using patch... ASM will read a class file and then dump a new class file somewhere else. We need to pick up these new class files to add them to the appropriate package. We also need to play some games to make sure we annotate the Classpath and not the host VMs classes.

Show
Ian Rogers added a comment - Using ASM ( http://asm.objectweb.org/ ) I was able to write a program to add annotations to classes in less than 200 lines of Java. Adding annotations this way for files not within the RVM seems preferable to using patch... ASM will read a class file and then dump a new class file somewhere else. We need to pick up these new class files to add them to the appropriate package. We also need to play some games to make sure we annotate the Classpath and not the host VMs classes.

People

  • Assignee:
    Unassigned
    Reporter:
    Ian Rogers
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: