Redback

Roles and permissions calculation triggers too many db queries

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.2-beta-2, 1.2, 1.2.1, 1.2.2
  • Fix Version/s: 1.2.2
  • Component/s: authentication, authorization
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

while calculating effective roles and permissions redback runs queries against the db for each role until it figures out all the effective roles

In a system with 1200+ roles (continuum) that means 30000+ queries to the db when the user logs in

  1. File
    redback-227.diff
    17/Jun/09 8:29 PM
    20 kB
    Carlos Sanchez
  2. File
    redback-227-2.diff
    17/Jun/09 10:42 PM
    22 kB
    Carlos Sanchez

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. REDBACK-228 JPOX Ehcache adapter doesn't support pinAll

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is depended upon by

Bug - A problem which impairs or prevents the functions of the product. CONTINUUM-2510 Experiencing slow performance when there are many roles

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Carlos Sanchez added a comment -

have some improvements already, preparing a test case

Show
Carlos Sanchez added a comment - have some improvements already, preparing a test case
Hide
Permalink
Carlos Sanchez added a comment -

Attached patch enables counting the number of queries in the JDO tests and does a minor improvement in the getRoles operation.

I have changed pom and log4j config to print the SQL statements

working on bigger improvements

Show
Carlos Sanchez added a comment - Attached patch enables counting the number of queries in the JDO tests and does a minor improvement in the getRoles operation. I have changed pom and log4j config to print the SQL statements working on bigger improvements
Hide
Permalink
Carlos Sanchez added a comment -

The JPOX operation getObjectsById is just calling getObjectById, so the optimization is minimal, if jpox cant get multiple objects using only one SELECT then the only solution will be to enable caching.

See line 1671 in
http://jpox.svn.sourceforge.net/viewvc/jpox/platform/core/trunk/src/java/org/jpox/jdo/AbstractPersistenceManager.java?view=markup

The test cases are still useful to count the queries sent to the db vs cache

Show
Carlos Sanchez added a comment - The JPOX operation getObjectsById is just calling getObjectById, so the optimization is minimal, if jpox cant get multiple objects using only one SELECT then the only solution will be to enable caching. See line 1671 in http://jpox.svn.sourceforge.net/viewvc/jpox/platform/core/trunk/src/java/org/jpox/jdo/AbstractPersistenceManager.java?view=markup The test cases are still useful to count the queries sent to the db vs cache
Hide
Permalink
Carlos Sanchez added a comment -

Added ehcache class-based cache that allows customizing cache sizes for each persisted class, with an example ehcache.xml config file for redback

Test enables the cache and checks that the number of queries is lower as expected.

Show
Carlos Sanchez added a comment - Added ehcache class-based cache that allows customizing cache sizes for each persisted class, with an example ehcache.xml config file for redback Test enables the cache and checks that the number of queries is lower as expected.
Hide
Permalink
Carlos Sanchez added a comment -

Added the performance tests with ehcache enabled

Example log4j configuration https://svn.codehaus.org/redback/redback/trunk/redback-rbac/redback-rbac-providers/redback-rbac-jdo/src/test/resources/ehcache.xml

Show
Carlos Sanchez added a comment - Added the performance tests with ehcache enabled Example log4j configuration https://svn.codehaus.org/redback/redback/trunk/redback-rbac/redback-rbac-providers/redback-rbac-jdo/src/test/resources/ehcache.xml

People

  • Assignee:
    Carlos Sanchez
    Reporter:
    Carlos Sanchez
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: