Expose enums in model

Any news on this? It's been almost a year since the bug was reported and no one touched it yet.

It's been close to 2.5 years now. Is this a dead project?

I use 1.6.3 and 1.7-20070527.154641-2 version.

This is stack trace:

Exception in thread "main" com.thoughtworks.qdox.parser.ParseException: 
    syntax error @[35,20] in file:/...myclass.....java
	at com.thoughtworks.qdox.parser.impl.Parser.yyerror(Parser.java:716)
	at com.thoughtworks.qdox.parser.impl.Parser.yyparse(Parser.java:826)
	at com.thoughtworks.qdox.parser.impl.Parser.parse(Parser.java:697)
        ... my class

Since this issue has not been fully addressed, I modified my personal build of QDox to get enums working for my own needs.

The problem is that while QDox 1.7 successfully parses enums, the parser doesn't add them to the model. From a top-level application's perspective, QDox appears to ignore the enums.

My fix was to modify QDox's parser.y grammar to add each enum's member as a field. Consequently, my top-level application is able to iterate over the members of an enum like fields in a class.

// ----- ENUM

enum: enum_definition BRACEOPEN enum_body BRACECLOSE { builder.endClass(); fieldType = null; modifiers.clear(); };

enum_definition: modifiers ENUM IDENTIFIER opt_implements { cls.lineNumber = line; cls.modifiers.addAll(modifiers); cls.name = $3; cls.type = ClassDef.ENUM; builder.beginClass(cls); cls = new ClassDef(); fieldType = new TypeDef($3, 0); };

enum_body: enum_values | enum_values SEMI members;

enum_values: | enum_value | enum_value COMMA enum_values;

enum_value:
javadoc enum_constructor |
opt_annotations enum_constructor;

enum_constructor:
IDENTIFIER { makeField(new TypeDef($1, 0), ""); } |
IDENTIFIER CODEBLOCK { makeField(new TypeDef($1, 0), ""); } |
IDENTIFIER PARENBLOCK { makeField(new TypeDef($1, 0), ""); } |
IDENTIFIER PARENBLOCK CODEBLOCK { makeField(new TypeDef($1, 0), ""); };

I have attached a patch file.

Expose enum members to the model as fields

Andrew. Thanks for the patch.

If you can also supply a unit test that illustrates/proves the enum case, then we'll apply it

• Paul

EnumsModelTest.java is a sequel to EnumsTest.java, showing that parsed enums are accessed like fields in the QDox model.

Hi,

Have those patches been applied? I'd like to use this feature in a project. Which release can I get to use this?

Many thanks for your cool project!

Unfortunately the tests fail for the patch and unit test above :

-------------------------------------------------------------------------------
Test set: com.thoughtworks.qdox.EnumsModelTest
-------------------------------------------------------------------------------
Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec <<< FAILURE!
testAddEnumWithAnnotationToModel(com.thoughtworks.qdox.EnumsModelTest) Time elapsed: 0.008 sec <<< FAILURE!
junit.framework.AssertionFailedError: expected:<1> but was:<0>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:282)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:201)
at junit.framework.Assert.assertEquals(Assert.java:207)
at com.thoughtworks.qdox.EnumsModelTest.testAddEnumWithAnnotationToModel(EnumsModelTest.java:113)

testAddEnumWithFieldAndConstructorsToModel(com.thoughtworks.qdox.EnumsModelTest) Time elapsed: 0.002 sec <<< FAILURE!
junit.framework.AssertionFailedError: expected:<1> but was:<0>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:282)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:201)
at junit.framework.Assert.assertEquals(Assert.java:207)
at com.thoughtworks.qdox.EnumsModelTest.testAddEnumWithFieldAndConstructorsToModel(EnumsModelTest.java:162)

These tests verify that we can access enum fields in the model.
This is a sequel to EnumsTest.java.

The first version of EnumsModelTest.java that I submitted was too ambitious. It illustrated continued failure to associate annotations with enums.

However, despite not being able to annotate enums, the rest of the test was successful.

I have resubmitted a new version of EnumsModelTest.java that tests all the same things, except for the annotation of enums. It passes all tests.

The parser.y.diff patch is unchanged.

By request, I have re-created the patch from the same directory as the pom.xml.

Applied patch - which now passes all unit tests. Thanks!

yay!