QDox

Generics in field assignments

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6
  • Fix Version/s: 1.6
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

The parser should support generics in field assignments.

class X {
Object y = new HashMap<A,B>();
}

It used to support this, however I had to roll it back as it introduced a critical bug that caused the parser to barf when parsing fields containing < or > characters (QDOX-71), which is common in existing source code.

The following tests are already in place, but are failing:
GenericsTest.FIXME_testJiraQdox66()
LexerTest.FIXME_testGenericTypeAssignment()

  1. qdox-77.patch
    31/Mar/05 5:54 PM
    18 kB
    Mike Williams
  2. qdox-77-dirk-email.txt
    31/Mar/05 5:54 PM
    6 kB
    Mike Williams

Activity

Hide
Joe Walnes added a comment -

The changes I made to rollback the support are here.

http://cvs.codehaus.org/changelog/qdox/?cs=MAIN:joe:20050103131703

Show
Joe Walnes added a comment - The changes I made to rollback the support are here. http://cvs.codehaus.org/changelog/qdox/?cs=MAIN:joe:20050103131703
Hide
Mike Williams added a comment -

Dirk Moebius <dmoebius@gmx.net> has contributed a (much appreciated) patch.

I've attached the patch and his email.

Show
Mike Williams added a comment - Dirk Moebius <dmoebius@gmx.net> has contributed a (much appreciated) patch. I've attached the patch and his email.
Hide
Mike Williams added a comment -

Well, that took a while to commit

Actually, Mario Siegenthaler submitted a patch which looks very similar to Dirk's, and I ended up committing that.

Show
Mike Williams added a comment - Well, that took a while to commit Actually, Mario Siegenthaler submitted a patch which looks very similar to Dirk's, and I ended up committing that.

People

Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: