QDox
  1. QDox
  2. QDOX-72

JavaClass.getInnerClasses() misleadingly named

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6
    • Component/s: Java API
    • Labels:
      None
    • Environment:
      N/A
    • Number of attachments :
      0

      Description

      Re.

      http://qdox.codehaus.org/apidocs/com/thoughtworks/qdox/model/JavaClass.html#getInnerClasses()

      The method getInnerClasses() seems to actually be listing all nested classes, including static nested classes, not just inner classes. This is a common misuse of the term "inner class". For definitions see

      http://java.sun.com/docs/books/jls/second_edition/html/classes.doc.html

      and search for "nested" and "inner", specifically

      "An inner class is a nested class that is not explicitly or implicitly declared static."

      You might consider renaming the method to JavaClass.getNestedClasses() for this reason, unless you are really returning only inner classes.

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Mike Williams
            Reporter:
            Jesse Glick
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 30 minutes
              30m
              Remaining:
              Remaining Estimate - 30 minutes
              30m
              Logged:
              Time Spent - Not Specified
              Not Specified