QDox

Handling of MAC line endings

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.4
  • Component/s: Parser
  • Labels:
    None
  • Number of attachments :
    0

Description

While messing around with QDox, I noticed a few parse errors that I only explain by the fact the files use MACintosh line endings.

Here's a sample file that goes "syntax error @[44,1]"
http://cvs.sourceforge.net/viewcvs.py/xdoclet-plugins/xdoclet-plugins/plugin-beaninfo/src/test/java/org/xdoclet/plugin/beaninfo/BeanInfoPluginTestCase.java

As Mike Williams said, it looks like there's no handling for MAC line-ends in the Lexer.

Activity

Hide
Mike Williams added a comment -

I was incorrect about the QDox lexer not supporting Mac line-terminators (sorry Joe, if you're listening).

Regrettably, this is starting to look like a bug in JFlex. It appears to be triggered by the presence of the "%line" option in the JFlex input file. We added this recently to support location info for DocletTags.

Show
Mike Williams added a comment - I was incorrect about the QDox lexer not supporting Mac line-terminators (sorry Joe, if you're listening). Regrettably, this is starting to look like a bug in JFlex. It appears to be triggered by the presence of the "%line" option in the JFlex input file. We added this recently to support location info for DocletTags.
Hide
Mike Williams added a comment -

After some minor futzing with the JFlex input-file, this appears fixed. Greg, please confirm.

Show
Mike Williams added a comment - After some minor futzing with the JFlex input-file, this appears fixed. Greg, please confirm.
Hide
Grégory Joseph (old account) added a comment -

Yep, works neatly. Thanks.

Show
Grégory Joseph (old account) added a comment - Yep, works neatly. Thanks.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: