Details
Bug
Resolved
Major
Description
I suspect the method JavaParameter#getType()to give incorrect results for vararg-parameters, resulting in JavaClass#getMethodBySignature(String, Type[]) failing to correctly lookup existing methods.
getType() seems to just return the base type of a varargs-parameter. IMHO opinion the correct behaviour would be to return the corresponding array-type with dimension 1.
Example:
class Test {
method(String... param) {} // getType() returns Type 'String' instead of 'String[]'
method(String param) {} // getType() returns Type 'String' as well, so there's no way to distuingish the two methods
Result:
getMethodBySignature('method', new Type[] {new Type('String', 1)}) -> returns null
getMethodBySignature('method', new Type[] {new Type('String')}) -> returns first method
-> no way to retrieve second method at all?!
See attached test-case for a complete illustration of the problem, including a working JUnit-Test
Best regards,
Sam Bernet
Attachments
Activity
Funny, this morning I had a look to see if I missed some bugs and I noticed I still had to solve this one 
I've tried to work things out, but in the end I didn't like to solve this by changing Type to support varargs. It's just not the right place, it's JavaParameter vs. JavaClass/Type.
So I came up with another idea. Vararg says actually something about the method, why not solve it there? This way we're not hacking around, code adjustments are pretty straightforward.
Only one thing: getMethodBySignature(String name, Type[] types, boolean varArg) isn't possible, the signature is already in use where the boolean stands for 'useSuperclass'.
Another methodname is required. getVarargMethodBySignature is an option, but maybe it's better to try to keep this methods close to eachother by name like 'getMethod......', so it's easier for developers to recognize both methods.
Anybody any thoughts?
I've tried to work things out, but in the end I didn't like to solve this by changing Type to support varargs. It's just not the right place, it's JavaParameter vs. JavaClass/Type.
So I came up with another idea. Vararg says actually something about the method, why not solve it there? This way we're not hacking around, code adjustments are pretty straightforward.
Only one thing: getMethodBySignature(String name, Type[] types, boolean varArg) isn't possible, the signature is already in use where the boolean stands for 'useSuperclass'.
Another methodname is required. getVarargMethodBySignature is an option, but maybe it's better to try to keep this methods close to eachother by name like 'getMethod......', so it's easier for developers to recognize both methods.
Anybody any thoughts?
I think we can keep the model cleaner if we avoid a translation from the triple dots to a dimension. Right now I'm thinking of a new constructor, where you can set a varargs boolean. This way the signature is much easier to recognize.