jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • QDox
  • QDOX-168

Parsing JavadocComment (please validate)

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8, 1.9, 1.9.1
  • Fix Version/s: 1.10
  • Component/s: Parser
  • Labels:
    None
  • Testcase included:
    yes

Description

Untill now the javadoc comments were read by token/word. This works for most cases, but when comments are becomming complex because of the usage of asterikses (together with tabs and spaces) the result be slightly different then the input.
I've rewritten the lexer, where the reading is based on lines instead of tokens. This makes the result much more solid, but requires some special lexing.
One testcase had 2 javadoccomments in 1 line (no sourceformatting, just one line of code). To read untill the first javadocEnd I had to use regepx inside the lexer-tokenblock.

When this patch is validated we can probably solve several open issues which refer to the usage of javadocs.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    javadoc-relexed.patch
    20/Jun/09 8:23 AM
    15 kB
    Robert Scholte
  2. Text File
    qdox-168-fix.patch
    06/Aug/09 1:11 PM
    29 kB
    Robert Scholte

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. QDOX-154 JavaMethod#getComment() is parsed with an implicit order

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Paul Hammant added a comment - 03/Sep/09 8:06 AM

Robert's Patch applied, some whitespace tests fixed to accommodate small changes.

Show
Paul Hammant added a comment - 03/Sep/09 8:06 AM Robert's Patch applied, some whitespace tests fixed to accommodate small changes.

People

  • Assignee:
    Robert Scholte
    Reporter:
    Robert Scholte
Vote (0)
Watch (0)

Dates

  • Created:
    20/Jun/09 8:23 AM
    Updated:
    03/Sep/09 8:06 AM
    Resolved:
    03/Sep/09 8:06 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.