QDox

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6
• Fix Version/s: 1.8
• Component/s: None
• Labels:

  None

When while resolving a type "MyType", JavaSource.resolveTypeInternal has an "import my.package.name.MyType", the result is "my.package.name.MyType". This is wrong in cases when name denotes a class, not a package. In this case the result should be "my.package.name$MyType". This is because of line 168:

if (imports[i].endsWith("." + typeName)) return imports[i];

Also, "name.MyType" is being resolved to "my.package.name.MyType", which is wrong according to the Java Language Spec (JLS) [1], as one cannot import subpackages.

The attached patch changes the resolution to follow the JLS. Since one cannot decide if a type "MyType" should be resolved to "my.package.name.MyType" or "my.package.name$MyType" without having the actual classes, some cases where resolution returned a (possibly incorrect) result now return null (see "corrected" test cases).

[1] http://java.sun.com/docs/books/jls/third_edition/html/packages.html#7.5.1

1. 

   QDOX-125.patch

   28/Jun/07 9:09 AM

   10 kB

   Jochen Kuhnle

• Assignee:

  Paul Hammant

  Reporter:

  Jochen Kuhnle

• Created:

  28/Jun/07 8:58 AM

  Updated:

  30/Jan/09 4:16 PM

  Resolved:

  30/Jan/09 4:16 PM