Case issue in Os.isOs(). Creates hard to identify maven profile activation failures (Patch attached)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.3
  • Labels:
    None

Description

My os.name is Linux. If I use <name>Linux</name> in my pom.xml, the profile doesn't get activated. If I use <name>linux.. it is.

Problem probably created because the Os class mixes instance and class methods. Calls to instance methods are correctly handled (fields are case-lowered when set), while class ones are not (parameters are not case-lowered). Wonder if the issue was fixed in Ant...

I haven't tested the patch yet, having problems making maven reuse the fixed plexus-utils, but I believe this should work.

  1. Text File
    patch.txt
    03/May/06 11:26 AM
    1 kB
    Jerome Lacoste

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MNG-2814 OS name is only detected if lower cased

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jerome Lacoste added a comment -

I've tested that this indeed fixes my issues by updating plexus-utils jar in $MAVEN_HOME/core/

Show
Jerome Lacoste added a comment - I've tested that this indeed fixes my issues by updating plexus-utils jar in $MAVEN_HOME/core/
Hide
Permalink
Emmanuel Venisse added a comment -

Applied with some other changes

Show
Emmanuel Venisse added a comment - Applied with some other changes

People

  • Assignee:
    Emmanuel Venisse
    Reporter:
    Jerome Lacoste
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: