Plexus Utils

executeCommandLine with timeout leaves StreamPumpers pumping data to client after method is returned

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.6
  • Fix Version/s: 2.0.7
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    0

Description

When the interruptedexception is throw due to process timeout, the StreamPumper is not terminated or disabled in any way. This means the pumper can continue feeding data to the client even after executeCommandLine has returened. This is not a good idea and the caus of SUREFIRE-690

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-690 testSetCompleted called before testSetStarting when using m3 parallel builds

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-707 NullPointerException in ConcurrentReporterManager on testSkipped (@Ignore on test class)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-710 ConcurrentModificationException in ConcurrentReporterManager

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. PLXUTILS-131 Improper exception handling in executeCommandLine

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kristian Rosenvold added a comment - - edited

Fixed in 401347173783947805458893210afb3d37ade0ae

Show
Kristian Rosenvold added a comment - - edited Fixed in 401347173783947805458893210afb3d37ade0ae
Hide
Permalink
Kristian Rosenvold added a comment - - edited

The root cause of this "trouble" is the removal of the empty catch block in PLXUTILS-131, which turned out to be painful but important.

Show
Kristian Rosenvold added a comment - - edited The root cause of this "trouble" is the removal of the empty catch block in PLXUTILS-131 , which turned out to be painful but important.

People

  • Assignee:
    Kristian Rosenvold
    Reporter:
    Kristian Rosenvold
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: