Plexus Components

The Javac Compiler Wrapper breaks the Build on Warnings in Java 6.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: plexus-compiler
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Plexus-compiler-javac in its current version 1.5.3 is not capable of parsing Java 6 warning and/or error messages properly.

  1. Text File
    patch.txt
    01/Jan/08 4:11 AM
    2 kB
    Christian Bach

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MCOMPILER-59 Compilation fails on warning messages from javac (Java 6)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. MCOMPILER-140 Compiler error messages do not contain drive letter on windows

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Christian Bach added a comment -

A patch to deal with Java 6 warning / error lines in a more proper way.

Show
Christian Bach added a comment - A patch to deal with Java 6 warning / error lines in a more proper way.
Hide
Permalink
Christian Bach added a comment -

For example Maven 2 projects causing a build to fail on warnings see http://jira.codehaus.org/browse/MCOMPILER-59 .

Show
Christian Bach added a comment - For example Maven 2 projects causing a build to fail on warnings see http://jira.codehaus.org/browse/MCOMPILER-59 .
Hide
Permalink
John Casey added a comment -

Applied. Thanks for the patch!

I tested this using the warning.tar.gz attachement to MCOMPILER-59.

Show
John Casey added a comment - Applied. Thanks for the patch! I tested this using the warning.tar.gz attachement to MCOMPILER-59 .
Hide
Permalink
John Casey added a comment -

it appears this problem isn't solved yet. We're getting NullPointerExceptions with the newer version of plexus-compiler-* in the maven-compiler-plugin, and when I alleviate that, it seems like the new version of the plugin still isn't solving the problem.

I need to look into this further.

Show
John Casey added a comment - it appears this problem isn't solved yet. We're getting NullPointerExceptions with the newer version of plexus-compiler-* in the maven-compiler-plugin, and when I alleviate that, it seems like the new version of the plugin still isn't solving the problem. I need to look into this further.
Hide
Permalink
John Casey added a comment -

verified that I've got this fixed now. It appears that to actually build this project (plexus-compiler-javac) using java6, the expectedErrors() method of the javac unit test had to be adjusted to sense whether it was using <= 1.5, and adjust the expected number of errors up by one if not. This is because a misspelled modifier like 'publc' will result in TWO errors under 1.6, not just one.

Show
John Casey added a comment - verified that I've got this fixed now. It appears that to actually build this project (plexus-compiler-javac) using java6, the expectedErrors() method of the javac unit test had to be adjusted to sense whether it was using <= 1.5, and adjust the expected number of errors up by one if not. This is because a misspelled modifier like 'publc' will result in TWO errors under 1.6, not just one.
Hide
Permalink
Manoj Inukolunu added a comment -

how do i fix this

Show
Manoj Inukolunu added a comment - how do i fix this

People

  • Assignee:
    John Casey
    Reporter:
    Christian Bach
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: