Plexus Components

Possible problem with class files not being created by plexus-compiler-eclipse

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Duplicate
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: plexus-compiler
  • Labels:
    None
  • Environment:
    Mac OS X 10.3, Windows XP, probably others
  • Number of attachments :
    0

Description

I have only encountered this on Mac OS X 10.3, but the original reporter of MCOMPILER-43 encountered it in Windows XP.

Compiling via maven's compiler plugin, with the compilerId set to eclipse, not all of the .java files get turned into .class files.

I have tried using the eclipse compiler directly from the command line, and it doesn't have this problem.

I do not know whether this is an issue with maven-compiler-plugin, or with plexus-compiler-eclipse. But, given that maven-compiler-plugin works fine with plexus-compiler-javac, I would presume it is a problem with plexus-compiler-eclipse.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. PLXCOMP-119 Eclipse compile plugin fails to copy files containing warnings (PATCH for bug + upgrade to JDT 3.4.2)

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. MCOMPILER-43 Maven compiler creates ghost classes when invoked with a compilerId of 'eclipse'

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nicholas Daley added a comment -

I've had a look at the source for EclipseJavaCompiler.java.

It looks to me like it isn't creating a class file when there's any kind of problem, even if all of the problems are errors.

See the method acceptResult:
It only creates class files if result.hasProblems() returns false.

It should create class files when all of the problems are warnings.

if ( result.hasProblems() )
{
    IProblem[] problems = result.getProblems();

    for ( int i = 0; i < problems.length; i++ )
    {
        IProblem problem = problems[ i ];

        String name = new String( problems[ i ].getOriginatingFileName() );

        if ( problem.isWarning() )
        {
            errors.add( handleWarning( problem ) );
        }
        else
        {
            errors.add( handleError( name,
                                 problem.getSourceLineNumber(),
                                 -1,
                                 problem.getMessage() ) );
        }
    }
}
else
{
    ...
}

Should be changed to:

boolean errorFound = false;
if ( result.hasProblems() )
{
    IProblem[] problems = result.getProblems();

    for ( int i = 0; i < problems.length; i++ )
    {
        IProblem problem = problems[ i ];

        String name = new String( problems[ i ].getOriginatingFileName() );

        if ( problem.isWarning() )
        {
            errors.add( handleWarning( problem ) );
        }
        else
        {
            errorFound = true;
            errors.add( handleError( name,
                                 problem.getSourceLineNumber(),
                                 -1,
                                 problem.getMessage() ) );
        }
    }
}

if( !errorFound )
{
...
}
Show
Nicholas Daley added a comment - I've had a look at the source for EclipseJavaCompiler.java. It looks to me like it isn't creating a class file when there's any kind of problem, even if all of the problems are errors. See the method acceptResult: It only creates class files if result.hasProblems() returns false. It should create class files when all of the problems are warnings. if ( result.hasProblems() ) { IProblem[] problems = result.getProblems(); for ( int i = 0; i < problems.length; i++ ) { IProblem problem = problems[ i ]; String name = new String( problems[ i ].getOriginatingFileName() ); if ( problem.isWarning() ) { errors.add( handleWarning( problem ) ); } else { errors.add( handleError( name, problem.getSourceLineNumber(), -1, problem.getMessage() ) ); } } } else { ... } Should be changed to: boolean errorFound = false; if ( result.hasProblems() ) { IProblem[] problems = result.getProblems(); for ( int i = 0; i < problems.length; i++ ) { IProblem problem = problems[ i ]; String name = new String( problems[ i ].getOriginatingFileName() ); if ( problem.isWarning() ) { errors.add( handleWarning( problem ) ); } else { errorFound = true; errors.add( handleError( name, problem.getSourceLineNumber(), -1, problem.getMessage() ) ); } } } if( !errorFound ) { ... }
Hide
Permalink
Nicholas Daley added a comment -

D'oh. I didn't phrase that right in the last comment.

I should have said it isn't creating a class file even if all of the problems are warnings.

Show
Nicholas Daley added a comment - D'oh. I didn't phrase that right in the last comment. I should have said it isn't creating a class file even if all of the problems are warnings .
Hide
Permalink
Holger Hoffstätte added a comment -

This has to be a joke, right? Did anybody ever actually USE this plugin before releasing it?

Show
Holger Hoffstätte added a comment - This has to be a joke, right? Did anybody ever actually USE this plugin before releasing it?
Hide
Permalink
Pierce T. Wetter III added a comment -

Yeah, this is a show stopper for me because I've run into a bug in the javac compiler that eclipse doesn't have. Seems like the code is there already, someone just has to cut/paste it into the trunk!

Could someone do that please?

Show
Pierce T. Wetter III added a comment - Yeah, this is a show stopper for me because I've run into a bug in the javac compiler that eclipse doesn't have. Seems like the code is there already, someone just has to cut/paste it into the trunk! Could someone do that please?
Hide
Permalink
Benjamin Bentmann added a comment -

Applied patch from PLXCOMP-119 which followed the same solution as sketch here.

Show
Benjamin Bentmann added a comment - Applied patch from PLXCOMP-119 which followed the same solution as sketch here.

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Nicholas Daley
Vote (6)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: