Plexus Components

better validation of manifest entries in plexus-archiver

Details

  • Number of attachments :
    0

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. MSHARED-99 Archiver should validate manifest attribute names.

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Task - A task that needs to be done. PLXCOMP-172 remove Ant's Manifest class: use JDK's class instead

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jerome Lacoste added a comment -

According to the archived mail, here are the 3 rules to enforce.

1) All text must be UTF-8
2) Lines are limited to 72 characters; longer lines must be continued
3) Sections are divided by blank lines

To my knowledge, 2 has been fixed some months ago. There are still some people having issues in maven but I believe they use older plexus-archiver versions.

As for 1 and 3, I am not sure. These definitively need to be looked into.

Show
Jerome Lacoste added a comment - According to the archived mail, here are the 3 rules to enforce. 1) All text must be UTF-8 2) Lines are limited to 72 characters; longer lines must be continued 3) Sections are divided by blank lines To my knowledge, 2 has been fixed some months ago. There are still some people having issues in maven but I believe they use older plexus-archiver versions. As for 1 and 3, I am not sure. These definitively need to be looked into.
Hide
Permalink
Herve Boutemy added a comment -

according to the spec, lines are not limited to 72 characters but bytes
actual implementation (1.2) is broken since it write to a Writer, which cannot ensure such limitation (imagine a UTF-8 4-bytes characters happens at the 72nd byte)

Show
Herve Boutemy added a comment - according to the spec, lines are not limited to 72 characters but bytes actual implementation (1.2) is broken since it write to a Writer, which cannot ensure such limitation (imagine a UTF-8 4-bytes characters happens at the 72nd byte)
Hide
Permalink
Kristian Rosenvold added a comment -

Fixed in 838ab2e61ab6540631abe8a792292ea672e97a85, now uses JDK manifest class

Show
Kristian Rosenvold added a comment - Fixed in 838ab2e61ab6540631abe8a792292ea672e97a85, now uses JDK manifest class

People

  • Assignee:
    Kristian Rosenvold
    Reporter:
    Brett Porter
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: