Plexus Components

Plexus archiver overwrites custom MANIFEST.MFs

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: plexus-archiver
  • Labels:
    None
  • Number of attachments :
    0

Description

My WAR contains a custom MANIFEST.MF in order to reference EAR resources in its classpath but the war generated with maven2 will not work because plexus-archiver generates its own simple MANIFEST file which overwrites mine. Archiver should only create a manifest if one does not already exist.

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. MWAR-9 WAR plugin should support minimal WARs for inclusion within an EAR

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mike Perham added a comment -

See also MNG-1028

Show
Mike Perham added a comment - See also MNG-1028
Hide
Permalink
Carlos Sanchez added a comment -

I believe this has been fixed

Show
Carlos Sanchez added a comment - I believe this has been fixed
Hide
Permalink
Brett Porter added a comment -

Carlos - do you have a test to confirm?

Show
Brett Porter added a comment - Carlos - do you have a test to confirm?
Hide
Permalink
Carlos Sanchez added a comment -

This was an issue with the assembly plugin and was fixed for Celix I think
If I had a test I would have closed the issue

Show
Carlos Sanchez added a comment - This was an issue with the assembly plugin and was fixed for Celix I think If I had a test I would have closed the issue
Hide
Permalink
Brett Porter added a comment -

I'm not sure... this is the WAR plugin, not the assembly plugin, but it might be the same issue.

Show
Brett Porter added a comment - I'm not sure... this is the WAR plugin, not the assembly plugin, but it might be the same issue.
Hide
Permalink
Sebastien Brunot added a comment -

I've got exactly the same problem with the EAR plugin.

Show
Sebastien Brunot added a comment - I've got exactly the same problem with the EAR plugin.
Hide
Permalink
Stéphane Nicoll added a comment -

is this one archiver dependent or is it something to fix in the plugins?

Show
Stéphane Nicoll added a comment - is this one archiver dependent or is it something to fix in the plugins?
Hide
Permalink
Stéphane Nicoll added a comment -

It's fixed, at least in the EAR plugin. I have a test case that reproduce this scenario and the custom manifest is included.

Can anyone close this issue?

Show
Stéphane Nicoll added a comment - It's fixed, at least in the EAR plugin. I have a test case that reproduce this scenario and the custom manifest is included. Can anyone close this issue?
Hide
Permalink
Rémy Sanlaville added a comment -

I still have the problem with the war plugin.

My custom manifest
Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven
Built-By: USER000
Build-Jdk: 1.5.0_07
Extension-Name: war-common
Implementation-Title: war-common
Implementation-Version: 1.0-SNAPSHOT
Class-Path: properties
Manifest in the war archive
Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven
Built-By: USER000
Build-Jdk: 1.5.0_07
Show
Rémy Sanlaville added a comment - I still have the problem with the war plugin. My custom manifest Manifest-Version: 1.0 Archiver-Version: Plexus Archiver Created-By: Apache Maven Built-By: USER000 Build-Jdk: 1.5.0_07 Extension-Name: war-common Implementation-Title: war-common Implementation-Version: 1.0-SNAPSHOT Class -Path: properties Manifest in the war archive Manifest-Version: 1.0 Archiver-Version: Plexus Archiver Created-By: Apache Maven Built-By: USER000 Build-Jdk: 1.5.0_07
Hide
Permalink
Olivier Lamy added a comment -

IMHO it's not a PLX issue but a MWAR issue because it's possible to use a custom manifest in the the jar plugin.

Show
Olivier Lamy added a comment - IMHO it's not a PLX issue but a MWAR issue because it's possible to use a custom manifest in the the jar plugin.
Hide
Permalink
Rémy Sanlaville added a comment -

Ok, I will look at the maven-war-plugin.

Even if it is possible to generate a custom manifest has described in war-manifest-guide, it's not what I need in my case.

In my context, I also use the overlays mechanism and I would like to keep the manifest from my common war. It seems that is not possible to combine both custom manifest and overlays because the maven-war-plugin can't take into account an existing manifest. It can just generate a new one with the corresponding configuration in the pom.

I will look if I found a solution and if not I will open an improvement for the maven-war-plugin.

Show
Rémy Sanlaville added a comment - Ok, I will look at the maven-war-plugin. Even if it is possible to generate a custom manifest has described in war-manifest-guide , it's not what I need in my case. In my context, I also use the overlays mechanism and I would like to keep the manifest from my common war. It seems that is not possible to combine both custom manifest and overlays because the maven-war-plugin can't take into account an existing manifest. It can just generate a new one with the corresponding configuration in the pom. I will look if I found a solution and if not I will open an improvement for the maven-war-plugin.
Hide
Permalink
Rémy Sanlaville added a comment -

I have opened the following issue MWAR-142

Show
Rémy Sanlaville added a comment - I have opened the following issue MWAR-142
Hide
Permalink
Olivier Lamy added a comment -

I close it because it's possible to use a custom manifest with plexus archiver

Show
Olivier Lamy added a comment - I close it because it's possible to use a custom manifest with plexus archiver

People

  • Assignee:
    Unassigned
    Reporter:
    Mike Perham
Vote (5)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: