Plexus Components

PlexusIoResourceAttributeUtils - GroupId may not be set on partial overrides

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: plexus-io-2.0.2, plexus-archiver-2.0.2
  • Fix Version/s: plexus-io-2.0.3
  • Component/s: plexus-io
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

I have a case where I am using the TarArchiver and in creating the archive there is a call to PlexusIoResourceAttributeUtils.mergeAttributes where the base parameter is null. This throws an NPE as some of the calls to getXXXId() return an Integer and this is null.

I have changed this to check for null before the comparison to -1.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. PLXCOMP-200 PlexusIoResourceAttributeUtils can cause NPE if the base parameter is null

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. PLXCOMP-220 [REGRESSION] Tar archiver produces tar files with invalid uid/gid fields on Windows

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alex Koon added a comment -

Sorry - clone went wrong.

This issue is when an override may only have partial information such as only an override for a user id and not group id.

The patch attached fixes this issue (as a result of Sergei Ivanov's input to the previous fix for an NPE)

Show
Alex Koon added a comment - Sorry - clone went wrong. This issue is when an override may only have partial information such as only an override for a user id and not group id. The patch attached fixes this issue (as a result of Sergei Ivanov's input to the previous fix for an NPE)
Hide
Permalink
Sergei Ivanov added a comment -

Kristian, this patch has made its way into plexus-io-2.0.4 and plexus-archiver-2.1.2 respectively, and may be resolved and closed now. Please change "affected versions" to plexus-io-2.0.3 and plexus-archiver-2.1.1. Thank you.

Show
Sergei Ivanov added a comment - Kristian, this patch has made its way into plexus-io-2.0.4 and plexus-archiver-2.1.2 respectively, and may be resolved and closed now. Please change "affected versions" to plexus-io-2.0.3 and plexus-archiver-2.1.1. Thank you.

People

  • Assignee:
    Kristian Rosenvold
    Reporter:
    Alex Koon
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: