Plexus Components

Wrong default directory attribute in archives

Details

  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

This is easy to fix.

When creating a ZIP with plexus-archiver, normally directories are added with a wrong attribute.
Listing such a ZIP file with "zipinfo" or "unzip -Z" in the command line shows directories as having the attribute "?" instead of "d". Such files cannot be opened with Midnight Commander or Krusader.

This behavior is there since plexus-archiver 1.0-alpha-12; version 1.0-alpha-10 didn't have it.

I've attached a patch which I have tested with the actual trunk version 1.3-SNAPSHOT and it works. Also the unit tests finish successfully.

This can be tested with maven-assembly-plugin:2.2-beta-5 for example, which depends on plexus-archiver 1.0-alpha-12.
maven-assembly-plugin:2.2-beta-2 in turn uses plexus-archiver 1.0-alpha-10 and doesn't show this behaviour.

I would have commited the fix into SVN myself if I had an account...

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MASSEMBLY-422 Generated directories have wrong file attributes

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kristian Rosenvold added a comment -

Fixed in a159f8355f957966e011b523a1698ee17900c7fc, thanks for the patch !

Note that plexus archiver is now at https://github.com/sonatype/plexus-archiver

I will try to redeploy the site to get the url's updated

Show
Kristian Rosenvold added a comment - Fixed in a159f8355f957966e011b523a1698ee17900c7fc, thanks for the patch ! Note that plexus archiver is now at https://github.com/sonatype/plexus-archiver I will try to redeploy the site to get the url's updated
Hide
Permalink
Chris Rankin added a comment -

Could we have a release of plexus-archiver-2.2, please? I've just spent the entire morning banging my head against MASSEMBLY-422, and its very frustrating to know that the fix has been sitting uselessly in the codebase for the past 4 months.

Show
Chris Rankin added a comment - Could we have a release of plexus-archiver-2.2 , please? I've just spent the entire morning banging my head against MASSEMBLY-422 , and its very frustrating to know that the fix has been sitting uselessly in the codebase for the past 4 months.
Hide
Permalink
Olivier Lamy added a comment -

fix version is 2.1.1

Show
Olivier Lamy added a comment - fix version is 2.1.1
Hide
Permalink
Chris Rankin added a comment -

Ah, thanks. It must have been the Fix Version/s: plexus-archiver-2.2 section at the top of the JIRA which confused me.

Show
Chris Rankin added a comment - Ah, thanks. It must have been the Fix Version/s: plexus-archiver-2.2 section at the top of the JIRA which confused me.
Hide
Permalink
Olivier Lamy added a comment -

Correct but personally I don't have karma to create version in this project.

Show
Olivier Lamy added a comment - Correct but personally I don't have karma to create version in this project.

People

  • Assignee:
    Kristian Rosenvold
    Reporter:
    Rolf Schuster
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
1h
Original Estimate - 1 hour
Remaining:
1h
Remaining Estimate - 1 hour
Logged:
Not Specified
Time Spent - Not Specified