Plexus Components

[plexus-interpolation] Meaningless message printed for cycles from PrefixAwareRecursionInterceptor

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    JDK 6u21, Ubuntu, Maven 3.0 RC2, plexus-interpolation-1.11
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

In the course of trying to diagnose https://netbeans.org/bugzilla/show_bug.cgi?id=190530 I have found the messages from InterpolationCycleException to be misleading when PrefixAwareRecursionInterceptor is used: nakedExpressions contains the trimmed expression, not (necessarily) the raw expression, so getExpressionCycle must reflect that and not just return an empty list.

Patch seems to fix this. Also improves exception reporting a bit.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MNG-4836 Incorrect recursive expression cycle errors (update plexus-interpolation)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Hide
Permalink
Benjamin Bentmann added a comment -

Applied in r8754, thanks!

Show
Benjamin Bentmann added a comment - Applied in r8754 , thanks!

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Jesse Glick
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: